r39311 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r39310‎ | r39311 | r39312 >
Date:23:05, 13 August 2008
Author:brion
Status:old
Tags:
Comment:
1) Fix email check to load localizations so it logs properly
2) Disable email logging for now -- violates our present privacy policy by logging information that we currently say is kept private (email addresses) as well as information we don't mention but which feel very creepy to log for checkuser view (subject line of mails and times and targets of private mails)
Modified paths:
  • /trunk/extensions/CheckUser/CheckUser.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CheckUser/CheckUser.php
@@ -35,7 +35,7 @@
3636 # Recent changes data hook
3737 global $wgHooks;
3838 $wgHooks['RecentChange_save'][] = 'efUpdateCheckUserData';
39 -$wgHooks['EmailUser'][] = 'efUpdateCheckUserEmailData';
 39+//$wgHooks['EmailUser'][] = 'efUpdateCheckUserEmailData'; // do not use at present
4040
4141 $wgHooks['ParserTestTables'][] = 'efCheckUserParserTestTables';
4242 $wgHooks['LoadExtensionSchemaUpdates'][] = 'efCheckUserSchemaUpdates';
@@ -115,6 +115,8 @@
116116 * Saves user data into the cu_changes table
117117 */
118118 function efUpdateCheckUserEmailData( $to, $from, $subject, $text ) {
 119+ die("Do not use at present.");
 120+ wfLoadExtensionMessages( 'CheckUser' );
119121 $user = User::newFromName( $to->name );
120122 $userPage = $user->getUserPage();
121123 // Get IP

Status & tagging log