r39291 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r39290‎ | r39291 | r39292 >
Date:16:05, 13 August 2008
Author:yaron
Status:old
Tags:
Comment:
Fixed handling of quotes in title names
Modified paths:
  • /trunk/extensions/SemanticGoogleMaps/SGM_QueryPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticGoogleMaps/SGM_QueryPrinter.php
@@ -153,9 +153,10 @@
154154 // add a marker to the map for each location
155155 foreach ($locations as $i => $location) {
156156 list($lat, $lon, $title, $label) = $location;
 157+ $title = str_replace("'", "\'", $title);
157158 $label = str_replace("'", "\'", $label);
158159 $map_text .=<<<END
159 - map.addOverlay(createMarker(new GLatLng($lat, $lon), "$title", '$label'));
 160+ map.addOverlay(createMarker(new GLatLng($lat, $lon), '$title', '$label'));
160161 END;
161162 }
162163

Status & tagging log