r39153 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r39152‎ | r39153 | r39154 >
Date:16:24, 11 August 2008
Author:ialex
Status:old
Tags:
Comment:
(bug 15101) Displaying only bots edits in Special:Recentchanges now works again
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialRecentchanges.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRecentchanges.php
@@ -572,8 +572,9 @@
573573 function makeOptionsLink( $title, $override, $options, $active = false ) {
574574 global $wgUser;
575575 $sk = $wgUser->getSkin();
576 - return $sk->makeKnownLinkObj( $this->getTitle(), htmlspecialchars( $title ),
577 - wfArrayToCGI( $override, $options ), '', '', $active ? 'style="font-weight: bold;"' : '' );
 576+ $params = wfArrayMerge( $options, $override );
 577+ return $sk->link( $this->getTitle(), htmlspecialchars( $title ),
 578+ ( $active ? array( 'style'=>'font-weight: bold;' ) : array() ), $params, array( 'known' ) );
578579 }
579580
580581 /**
@@ -601,28 +602,28 @@
602603 # Sort data for display and make sure it's unique after we've added user data.
603604 $wgRCLinkLimits[] = $options['limit'];
604605 $wgRCLinkDays[] = $options['days'];
605 - sort($wgRCLinkLimits);
606 - sort($wgRCLinkDays);
607 - $wgRCLinkLimits = array_unique($wgRCLinkLimits);
608 - $wgRCLinkDays = array_unique($wgRCLinkDays);
 606+ sort( $wgRCLinkLimits );
 607+ sort( $wgRCLinkDays );
 608+ $wgRCLinkLimits = array_unique( $wgRCLinkLimits );
 609+ $wgRCLinkDays = array_unique( $wgRCLinkDays );
609610
610611 // limit links
611612 foreach( $wgRCLinkLimits as $value ) {
612613 $cl[] = $this->makeOptionsLink( $wgLang->formatNum( $value ),
613614 array( 'limit' => $value ), $nondefaults, $value == $options['limit'] ) ;
614615 }
615 - $cl = implode( ' | ', $cl);
 616+ $cl = implode( ' | ', $cl );
616617
617618 // day links, reset 'from' to none
618619 foreach( $wgRCLinkDays as $value ) {
619620 $dl[] = $this->makeOptionsLink( $wgLang->formatNum( $value ),
620621 array( 'days' => $value, 'from' => '' ), $nondefaults, $value == $options['days'] ) ;
621622 }
622 - $dl = implode( ' | ', $dl);
 623+ $dl = implode( ' | ', $dl );
623624
624625
625626 // show/hide links
626 - $showhide = array( wfMsg( 'show' ), wfMsg( 'hide' ));
 627+ $showhide = array( wfMsg( 'show' ), wfMsg( 'hide' ) );
627628 $minorLink = $this->makeOptionsLink( $showhide[1-$options['hideminor']],
628629 array( 'hideminor' => 1-$options['hideminor'] ), $nondefaults);
629630 $botLink = $this->makeOptionsLink( $showhide[1-$options['hidebots']],
@@ -647,11 +648,11 @@
648649
649650 // show from this onward link
650651 $now = $wgLang->timeanddate( wfTimestampNow(), true );
651 - $tl = $this->makeOptionsLink( $now, array( 'from' => wfTimestampNow()), $nondefaults );
 652+ $tl = $this->makeOptionsLink( $now, array( 'from' => wfTimestampNow() ), $nondefaults );
652653
653 - $rclinks = wfMsgExt( 'rclinks', array( 'parseinline', 'replaceafter'),
 654+ $rclinks = wfMsgExt( 'rclinks', array( 'parseinline', 'replaceafter' ),
654655 $cl, $dl, $hl );
655 - $rclistfrom = wfMsgExt( 'rclistfrom', array( 'parseinline', 'replaceafter'), $tl );
 656+ $rclistfrom = wfMsgExt( 'rclistfrom', array( 'parseinline', 'replaceafter' ), $tl );
656657 return "$note<br />$rclinks<br />$rclistfrom";
657658 }
658659 }
Index: trunk/phase3/RELEASE-NOTES
@@ -87,19 +87,22 @@
8888 Patch by Max Semenik.
8989 * (bug 15055) Talk page notifications no longer attempt to send mail when
9090 user's e-mail address is invalid or unconfirmed
91 -* (bug 12370) Add throttle on password attempts. Defaults to max 5 attempts in 5 minutes.
92 -* (bug 15016) 'Templates used on this page' list in view source should be wrapped
93 - in a div with class "templatesUsed"
 91+* (bug 12370) Add throttle on password attempts. Defaults to max 5 attempts in 5
 92+ minutes.
 93+* (bug 15016) 'Templates used on this page' list in view source should be
 94+ wrapped in a div with class "templatesUsed"
9495 * (bug 14868) Setting $wgFeedDiffCutoff to 0 now disables generation of the diff
9596 entirely, not just the display of it.
9697 * (bug 6387) Introduced new setting $wgCategoryPrefixedDefaultSortkey which
9798 allows having the unprefixed page title as the default category sortkey
98 -* (bug 15079) Add class="ns-talk" / "ns-subject" to <body>. Also added ns-special to
99 - special pages.
 99+* (bug 15079) Add class="ns-talk" / "ns-subject" to <body>. Also added
 100+ ns-special to special pages.
100101 * (bug 15052) Skins should add their name as a class in <body>
101102 * (bug 14165, bug 14294) Wikimedia specific configuration in convertGrammar()
102103 for several languages was removed. The settings have been put in extension
103104 WikimediaMessages. Patch for Czech by Danny B.
 105+* (bug 15101) Displaying only bots edits in Special:Recentchanges now works
 106+ again
104107
105108 === API changes in 1.14 ===
106109

Status & tagging log