r39152 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r39151‎ | r39152 | r39153 >
Date:15:44, 11 August 2008
Author:demon
Status:old
Tags:
Comment:
More of the ongoing war against mkdir() in favor of wfMkdirParents()
Modified paths:
  • /trunk/phase3/includes/Math.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Math.php
@@ -47,7 +47,7 @@
4848 if( !$this->_recall() ) {
4949 # Ensure that the temp and output directories are available before continuing...
5050 if( !file_exists( $wgTmpDirectory ) ) {
51 - if( !@mkdir( $wgTmpDirectory ) ) {
 51+ if( !wfMkdirParents( $wgTmpDirectory ) ) {
5252 return $this->_error( 'math_bad_tmpdir' );
5353 }
5454 } elseif( !is_dir( $wgTmpDirectory ) || !is_writable( $wgTmpDirectory ) ) {

Status & tagging log