r38998 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38997‎ | r38998 | r38999 >
Date:13:58, 9 August 2008
Author:ialex
Status:old
Tags:
Comment:
Fixed E_STRICT and escaping issue
Modified paths:
  • /trunk/extensions/Translate/utils/ToolBox.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/utils/ToolBox.php
@@ -7,7 +7,7 @@
88 * available translations for a message. Only shown when it
99 * actually is a translatable/translated message.
1010 */
11 - function toolboxAllTranslations(&$skin) {
 11+ static function toolboxAllTranslations(&$skin) {
1212 global $wgTitle;
1313
1414 $inMessageGroup = TranslateUtils::messageKeyToGroup( $wgTitle->getNamespace(), $wgTitle->getBaseText() );
@@ -18,7 +18,7 @@
1919 // Add a slash at the end, to not have basename in the result of Special:Prefixindex
2020 $prefix = $wgTitle->getNsText().":".$wgTitle->getBaseText()."/";
2121 $desc = wfMsg( 'translate-sidebar-alltrans' );
22 - $url = SpecialPage::getTitleFor( 'Prefixindex' )->getLocalURL('from='.$prefix);
 22+ $url = htmlspecialchars( SpecialPage::getTitleFor( 'Prefixindex' )->getLocalURL('from='.$prefix) );
2323
2424 // Add the actual toolbox entry.
2525 // Add newlines and tabs for nicer HTML output.

Status & tagging log