r38758 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38757‎ | r38758 | r38759 >
Date:09:34, 7 August 2008
Author:raymond
Status:old
Tags:
Comment:
Revert r38753 - crap diff...
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)
  • /trunk/phase3/maintenance/Doxyfile (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/Doxyfile
@@ -16,7 +16,7 @@
1717 PROJECT_NAME = MediaWiki
1818 PROJECT_NUMBER = {{CURRENT_VERSION}}
1919 OUTPUT_DIRECTORY = {{OUTPUT_DIRECTORY}}
20 -CREATE_SUBDIRS = YES
 20+CREATE_SUBDIRS = NO
2121 OUTPUT_LANGUAGE = English
2222 BRIEF_MEMBER_DESC = YES
2323 REPEAT_BRIEF = YES
@@ -175,7 +175,7 @@
176176 HHC_LOCATION =
177177 GENERATE_CHI = NO
178178 BINARY_TOC = NO
179 -TOC_EXPAND = YES
 179+TOC_EXPAND = NO
180180 DISABLE_INDEX = NO
181181 ENUM_VALUES_PER_LINE = 4
182182 GENERATE_TREEVIEW = YES
@@ -191,8 +191,8 @@
192192 PAPER_TYPE = a4wide
193193 EXTRA_PACKAGES =
194194 LATEX_HEADER =
195 -PDF_HYPERLINKS = YES
196 -USE_PDFLATEX = YES
 195+PDF_HYPERLINKS = NO
 196+USE_PDFLATEX = NO
197197 LATEX_BATCHMODE = NO
198198 LATEX_HIDE_INDICES = NO
199199 #---------------------------------------------------------------------------
@@ -207,7 +207,7 @@
208208 #---------------------------------------------------------------------------
209209 # configuration options related to the man page output
210210 #---------------------------------------------------------------------------
211 -GENERATE_MAN = NO
 211+GENERATE_MAN = YES
212212 MAN_OUTPUT = man
213213 MAN_EXTENSION = .3
214214 MAN_LINKS = NO
Index: trunk/phase3/includes/User.php
@@ -461,13 +461,8 @@
462462 * addresses like this, if we allowed accounts like this to be created
463463 * new users could get the old edits of these anonymous users.
464464 *
465 -<<<<<<< .mine
466 - * @param $name \type{\string} String to match
467 - * @return \type{\bool} True or false
468 -=======
469465 * @param $name \type{\string}
470466 * @return \type{\bool}
471 ->>>>>>> .r38752
472467 */
473468 static function isIP( $name ) {
474469 return preg_match('/^\d{1,3}\.\d{1,3}\.\d{1,3}\.(?:xxx|\d{1,3})$/',$name) || IP::isIPv6($name);
@@ -481,13 +476,8 @@
482477 * is longer than the maximum allowed username size or doesn't begin with
483478 * a capital letter.
484479 *
485 -<<<<<<< .mine
486 - * @param $name \type{\string} String to match
487 - * @return \type{\bool} True or false
488 -=======
489480 * @param $name \type{\string}
490481 * @return \type{\bool}
491 ->>>>>>> .r38752
492482 */
493483 static function isValidUserName( $name ) {
494484 global $wgContLang, $wgMaxNameChars;
@@ -540,13 +530,8 @@
541531 * If an account already exists in this form, login will be blocked
542532 * by a failure to pass this function.
543533 *
544 -<<<<<<< .mine
545 - * @param $name \type{\string} String to match
546 - * @return \type{\bool} True or false
547 -=======
548534 * @param $name \type{\string}
549535 * @return \type{\bool}
550 ->>>>>>> .r38752
551536 */
552537 static function isUsableName( $name ) {
553538 global $wgReservedUsernames;
@@ -577,13 +562,8 @@
578563 * rather than in isValidUserName() to avoid disrupting
579564 * existing accounts.
580565 *
581 -<<<<<<< .mine
582 - * @param $name \type{\string} String to match
583 - * @return \type{\bool} True or false
584 -=======
585566 * @param $name \type{\string}
586567 * @return \type{\bool}
587 ->>>>>>> .r38752
588568 */
589569 static function isCreatableName( $name ) {
590570 return
@@ -596,13 +576,8 @@
597577 /**
598578 * Is the input a valid password for this user?
599579 *
600 -<<<<<<< .mine
601580 * @param $password \type{\string} Desired password
602 - * @return \type{\bool} True or false
603 -=======
604 - * @param $password \type{\string} Desired password
605581 * @return \type{\bool}
606 ->>>>>>> .r38752
607582 */
608583 function isValidPassword( $password ) {
609584 global $wgMinimalPasswordLength, $wgContLang;
@@ -627,13 +602,8 @@
628603 *
629604 * @todo Check for RFC 2822 compilance (bug 959)
630605 *
631 -<<<<<<< .mine
632606 * @param $addr \type{\string} E-mail address
633 - * @return \type{\bool} True or false
634 -=======
635 - * @param $addr \type{\string} E-mail address
636607 * @return \type{\bool}
637 ->>>>>>> .r38752
638608 */
639609 public static function isValidEmailAddr( $addr ) {
640610 $result = null;
@@ -741,11 +711,7 @@
742712 * Return a random password. Sourced from mt_rand, so it's not particularly secure.
743713 * @todo hash random numbers to improve security, like generateToken()
744714 *
745 -<<<<<<< .mine
746 - * @return \type{\string} New random password
747 -=======
748715 * @return \type{\string}
749 ->>>>>>> .r38752
750716 */
751717 static function randomPassword() {
752718 global $wgMinimalPasswordLength;
@@ -1006,13 +972,8 @@
1007973 /**
1008974 * Get a given default option value.
1009975 *
1010 -<<<<<<< .mine
1011976 * @param $opt \type{\string} Name of option to retrieve
1012 - * @return \type{\string} Default option value
1013 -=======
1014 - * @param $opt \type{\string} Name of option to retrieve
1015977 * @return \type{\string}
1016 ->>>>>>> .r38752
1017978 */
1018979 public static function getDefaultOption( $opt ) {
1019980 $defOpts = self::getDefaultOptions();
@@ -1025,7 +986,7 @@
1026987
1027988 /**
1028989 * Get a list of user toggle names
1029 - * @return \arrayof{\string} Array of user toggle names
 990+ * @return \arrayof{\string}
1030991 */
1031992 static function getToggles() {
1032993 global $wgContLang;
@@ -1112,13 +1073,8 @@
11131074 /**
11141075 * Whether the given IP is in the SORBS blacklist.
11151076 *
1116 -<<<<<<< .mine
11171077 * @param $ip \type{\string} IP to check
1118 - * @return \type{\bool} True if blacklisted
1119 -=======
1120 - * @param $ip \type{\string} IP to check
11211078 * @return \type{\bool}
1122 ->>>>>>> .r38752
11231079 */
11241080 function inSorbsBlacklist( $ip ) {
11251081 global $wgEnableSorbs, $wgSorbsUrl;
@@ -1130,15 +1086,9 @@
11311087 /**
11321088 * Whether the given IP is in a given DNS blacklist.
11331089 *
1134 -<<<<<<< .mine
11351090 * @param $ip \type{\string} IP to check
11361091 * @param $base \type{\string} URL of the DNS blacklist
1137 - * @return \type{\bool} True if blacklisted
1138 -=======
1139 - * @param $ip \type{\string} IP to check
1140 - * @param $base \type{\string} URL of the DNS blacklist
11411092 * @return \type{\bool}
1142 ->>>>>>> .r38752
11431093 */
11441094 function inDnsBlacklist( $ip, $base ) {
11451095 wfProfileIn( __METHOD__ );
@@ -1172,11 +1122,7 @@
11731123 /**
11741124 * Is this user subject to rate limiting?
11751125 *
1176 -<<<<<<< .mine
1177 - * @return \type{\bool} True if rate limited
1178 -=======
11791126 * @return \type{\bool}
1180 ->>>>>>> .r38752
11811127 */
11821128 public function isPingLimitable() {
11831129 global $wgRateLimitsExcludedGroups;
@@ -1365,11 +1311,7 @@
13661312
13671313 /**
13681314 * Get the user name, or the IP of an anonymous user
1369 -<<<<<<< .mine
1370 - * @return \type{\string} User's name or IP address
1371 -=======
13721315 * @return \type{\string}
1373 ->>>>>>> .r38752
13741316 */
13751317 function getName() {
13761318 if ( !$this->mDataLoaded && $this->mFrom == 'name' ) {
@@ -1405,11 +1347,7 @@
14061348
14071349 /**
14081350 * Get the user's name escaped by underscores.
1409 -<<<<<<< .mine
1410 - * @return \type{\string} Username escaped by underscores
1411 -=======
14121351 * @return \type{\string}
1413 ->>>>>>> .r38752
14141352 */
14151353 function getTitleKey() {
14161354 return str_replace( ' ', '_', $this->getName() );
@@ -1679,11 +1617,7 @@
16801618
16811619 /**
16821620 * Get the user's current token.
1683 -<<<<<<< .mine
1684 - * @return \type{\string} Token
1685 -=======
16861621 * @return \type{\string}
1687 ->>>>>>> .r38752
16881622 */
16891623 function getToken() {
16901624 $this->load();
@@ -1742,11 +1676,7 @@
17431677 /**
17441678 * Has password reminder email been sent within the last
17451679 * $wgPasswordReminderResendTime hours?
1746 -<<<<<<< .mine
1747 - * @return \type{\bool} True or false
1748 -=======
17491680 * @return \type{\bool}
1750 ->>>>>>> .r38752
17511681 */
17521682 function isPasswordReminderThrottled() {
17531683 global $wgPasswordReminderResendTime;
@@ -1760,11 +1690,7 @@
17611691
17621692 /**
17631693 * Get the user's e-mail address
1764 -<<<<<<< .mine
1765 - * @return \type{\string} User's -mail address
1766 -=======
17671694 * @return \type{\string}
1768 ->>>>>>> .r38752
17691695 */
17701696 function getEmail() {
17711697 $this->load();
@@ -1794,11 +1720,7 @@
17951721
17961722 /**
17971723 * Get the user's real name
1798 -<<<<<<< .mine
1799 - * @return \type{\string} User's real name
1800 -=======
18011724 * @return \type{\string}
1802 ->>>>>>> .r38752
18031725 */
18041726 function getRealName() {
18051727 $this->load();
@@ -1900,11 +1822,7 @@
19011823
19021824 /**
19031825 * Get the user's preferred date format.
1904 -<<<<<<< .mine
1905 - * @return \type{\string} User's preferred date format
1906 -=======
19071826 * @return \type{\string}
1908 ->>>>>>> .r38752
19091827 */
19101828 function getDatePreference() {
19111829 // Important migration for old data rows
@@ -1922,7 +1840,7 @@
19231841
19241842 /**
19251843 * Get the permissions this user has.
1926 - * @return \arrayof{\string} Array of permission names
 1844+ * @return \arrayof{\string}
19271845 */
19281846 function getRights() {
19291847 if ( is_null( $this->mRights ) ) {
@@ -1937,7 +1855,7 @@
19381856 /**
19391857 * Get the list of explicit group memberships this user has.
19401858 * The implicit * and user groups are not included.
1941 - * @return \arrayof{\string} Array of internal group names
 1859+ * @return \arrayof{\string}
19421860 */
19431861 function getGroups() {
19441862 $this->load();
@@ -1948,13 +1866,8 @@
19491867 * Get the list of implicit group memberships this user has.
19501868 * This includes all explicit groups, plus 'user' if logged in,
19511869 * '*' for all accounts and autopromoted groups
1952 -<<<<<<< .mine
19531870 * @param $recache \type{\bool} Whether to avoid the cache
1954 - * @return \arrayof{\string} Array of internal group names
1955 -=======
1956 - * @param $recache \type{\bool} Whether to avoid the cache
19571871 * @return \arrayof{\string}
1958 ->>>>>>> .r38752
19591872 */
19601873 function getEffectiveGroups( $recache = false ) {
19611874 if ( $recache || is_null( $this->mEffectiveGroups ) ) {
@@ -1977,11 +1890,7 @@
19781891
19791892 /**
19801893 * Get the user's edit count.
1981 -<<<<<<< .mine
1982 - * @return \type{\int} User's edit count
1983 -=======
19841894 * @return \type{\int}
1985 ->>>>>>> .r38752
19861895 */
19871896 function getEditCount() {
19881897 if ($this->mId) {
@@ -2045,11 +1954,7 @@
20461955
20471956 /**
20481957 * Get whether the user is logged in
2049 -<<<<<<< .mine
2050 - * @return \type{\bool} True or false
2051 -=======
20521958 * @return \type{\bool}
2053 ->>>>>>> .r38752
20541959 */
20551960 function isLoggedIn() {
20561961 return $this->getID() != 0;
@@ -2057,11 +1962,7 @@
20581963
20591964 /**
20601965 * Get whether the user is anonymous
2061 -<<<<<<< .mine
2062 - * @return \type{\bool} True or false
2063 -=======
20641966 * @return \type{\bool}
2065 ->>>>>>> .r38752
20661967 */
20671968 function isAnon() {
20681969 return !$this->isLoggedIn();
@@ -2069,11 +1970,7 @@
20701971
20711972 /**
20721973 * Get whether the user is a bot
2073 -<<<<<<< .mine
2074 - * @return \type{\bool} True or false
2075 -=======
20761974 * @return \type{\bool}
2077 ->>>>>>> .r38752
20781975 * @deprecated
20791976 */
20801977 function isBot() {
@@ -2096,11 +1993,7 @@
20971994
20981995 /**
20991996 * Check whether to enable recent changes patrol features for this user
2100 -<<<<<<< .mine
2101 - * @return \type{\bool} True or false
2102 -=======
21031997 * @return \type{\bool}
2104 ->>>>>>> .r38752
21051998 */
21061999 public function useRCPatrol() {
21072000 global $wgUseRCPatrol;
@@ -2109,11 +2002,7 @@
21102003
21112004 /**
21122005 * Check whether to enable new pages patrol features for this user
2113 -<<<<<<< .mine
2114 - * @return \type{\bool} True or false
2115 -=======
21162006 * @return \type{\bool}
2117 ->>>>>>> .r38752
21182007 */
21192008 public function useNPPatrol() {
21202009 global $wgUseRCPatrol, $wgUseNPPatrol;
@@ -2122,7 +2011,7 @@
21232012
21242013 /**
21252014 * Get the current skin, loading it if required
2126 - * @return \type{Skin} Current skin
 2015+ * @return \type{Skin}
21272016 * @todo FIXME : need to check the old failback system [AV]
21282017 */
21292018 function &getSkin() {
@@ -2561,11 +2450,7 @@
25622451 * which will give them a chance to modify this key based on their own
25632452 * settings.
25642453 *
2565 -<<<<<<< .mine
2566 - * @return \type{\string} Page rendering hash
2567 -=======
25682454 * @return \type{\string}
2569 ->>>>>>> .r38752
25702455 */
25712456 function getPageRenderingHash() {
25722457 global $wgContLang, $wgUseDynamicDates, $wgLang;
@@ -2600,11 +2485,7 @@
26012486
26022487 /**
26032488 * Get whether the user is explicitly blocked from account creation.
2604 -<<<<<<< .mine
2605 - * @return \type{\bool} True if blocked
2606 -=======
26072489 * @return \type{\bool}
2608 ->>>>>>> .r38752
26092490 */
26102491 function isBlockedFromCreateAccount() {
26112492 $this->getBlockedStatus();
@@ -2613,11 +2494,7 @@
26142495
26152496 /**
26162497 * Get whether the user is blocked from using Special:Emailuser.
2617 -<<<<<<< .mine
2618 - * @return \type{\bool} True if blocked
2619 -=======
26202498 * @return \type{\bool}
2621 ->>>>>>> .r38752
26222499 */
26232500 function isBlockedFromEmailuser() {
26242501 $this->getBlockedStatus();
@@ -2626,11 +2503,7 @@
26272504
26282505 /**
26292506 * Get whether the user is allowed to create an account.
2630 -<<<<<<< .mine
2631 - * @return \type{\bool} True if allowed
2632 -=======
26332507 * @return \type{\bool}
2634 ->>>>>>> .r38752
26352508 */
26362509 function isAllowedToCreateAccount() {
26372510 return $this->isAllowed( 'createaccount' ) && !$this->isBlockedFromCreateAccount();
@@ -2646,7 +2519,7 @@
26472520 /**
26482521 * Get this user's personal page title.
26492522 *
2650 - * @return \type{Title} User's personal page title
 2523+ * @return \type{Title}
26512524 */
26522525 function getUserPage() {
26532526 return Title::makeTitle( NS_USER, $this->getName() );
@@ -2655,7 +2528,7 @@
26562529 /**
26572530 * Get this user's talk page title.
26582531 *
2659 - * @return \type{Title} User's talk page title
 2532+ * @return \type{Title}
26602533 */
26612534 function getTalkPage() {
26622535 $title = $this->getUserPage();
@@ -2664,11 +2537,7 @@
26652538
26662539 /**
26672540 * Get the maximum valid user ID.
2668 -<<<<<<< .mine
2669 - * @return \type{\int} %User ID
2670 -=======
26712541 * @return \type{\int}
2672 ->>>>>>> .r38752
26732542 * @static
26742543 */
26752544 function getMaxID() {
@@ -2760,11 +2629,7 @@
27612630 /**
27622631 * Check if the given clear-text password matches the temporary password
27632632 * sent by e-mail for password reset operations.
2764 -<<<<<<< .mine
2765 - * @return \type{\bool} True if matches, false otherwise
2766 -=======
27672633 * @return \type{\bool}
2768 ->>>>>>> .r38752
27692634 */
27702635 function checkTemporaryPassword( $plaintext ) {
27712636 return self::comparePasswords( $this->mNewpassword, $plaintext, $this->getId() );
@@ -2865,19 +2730,11 @@
28662731 * Send an e-mail to this user's account. Does not check for
28672732 * confirmed status or validity.
28682733 *
2869 -<<<<<<< .mine
28702734 * @param $subject \type{\string} Message subject
28712735 * @param $body \type{\string} Message body
28722736 * @param $from \type{\string} Optional From address; if unspecified, default $wgPasswordSender will be used
2873 - * @param $replyto \type{\string} Reply-to address
2874 - * @return \twotypes{\bool,WikiError} True on success, a WikiError object on failure
2875 -=======
2876 - * @param $subject \type{\string} Message subject
2877 - * @param $body \type{\string} Message body
2878 - * @param $from \type{\string} Optional From address; if unspecified, default $wgPasswordSender will be used
28792737 * @param $replyto \type{\string}
28802738 * @return \twotypes{\bool,WikiError} True on success, a WikiError object on failure
2881 ->>>>>>> .r38752
28822739 */
28832740 function sendMail( $subject, $body, $from = null, $replyto = null ) {
28842741 if( is_null( $from ) ) {
@@ -2897,13 +2754,8 @@
28982755 * @note Call saveSettings() after calling this function to commit
28992756 * this change to the database.
29002757 *
2901 -<<<<<<< .mine
29022758 * @param[out] &$expiration \type{\mixed} Accepts the expiration time
2903 - * @return \type{\string} New token
2904 -=======
2905 - * @param[out] &$expiration \type{\mixed} Accepts the expiration time
29062759 * @return \type{\string}
2907 ->>>>>>> .r38752
29082760 * @private
29092761 */
29102762 function confirmationToken( &$expiration ) {
@@ -2920,13 +2772,8 @@
29212773
29222774 /**
29232775 * Return a URL the user can use to confirm their email address.
2924 -<<<<<<< .mine
29252776 * @param $token \type{\string} Accepts the email confirmation token
2926 - * @return \type{\string} New token URL
2927 -=======
2928 - * @param $token \type{\string} Accepts the email confirmation token
29292777 * @return \type{\string}
2930 ->>>>>>> .r38752
29312778 * @private
29322779 */
29332780 function confirmationTokenUrl( $token ) {
@@ -2934,13 +2781,8 @@
29352782 }
29362783 /**
29372784 * Return a URL the user can use to invalidate their email address.
2938 -<<<<<<< .mine
29392785 * @param $token \type{\string} Accepts the email confirmation token
2940 - * @return \type{\string} New token URL
2941 -=======
2942 - * @param $token \type{\string} Accepts the email confirmation token
29432786 * @return \type{\string}
2944 ->>>>>>> .r38752
29452787 * @private
29462788 */
29472789 function invalidationTokenUrl( $token ) {
@@ -3007,11 +2849,7 @@
30082850 /**
30092851 * Is this user allowed to send e-mails within limits of current
30102852 * site configuration?
3011 -<<<<<<< .mine
3012 - * @return \type{\bool} True if allowed
3013 -=======
30142853 * @return \type{\bool}
3015 ->>>>>>> .r38752
30162854 */
30172855 function canSendEmail() {
30182856 $canSend = $this->isEmailConfirmed();
@@ -3022,11 +2860,7 @@
30232861 /**
30242862 * Is this user allowed to receive e-mails within limits of current
30252863 * site configuration?
3026 -<<<<<<< .mine
3027 - * @return \type{\bool} True if allowed
3028 -=======
30292864 * @return \type{\bool}
3030 ->>>>>>> .r38752
30312865 */
30322866 function canReceiveEmail() {
30332867 return $this->isEmailConfirmed() && !$this->getOption( 'disablemail' );
@@ -3040,11 +2874,7 @@
30412875 * confirmed their address by returning a code or using a password
30422876 * sent to the address from the wiki.
30432877 *
3044 -<<<<<<< .mine
3045 - * @return \type{\bool} True if conffirmed
3046 -=======
30472878 * @return \type{\bool}
3048 ->>>>>>> .r38752
30492879 */
30502880 function isEmailConfirmed() {
30512881 global $wgEmailAuthentication;
@@ -3065,11 +2895,7 @@
30662896
30672897 /**
30682898 * Check whether there is an outstanding request for e-mail confirmation.
3069 -<<<<<<< .mine
3070 - * @return \type{\bool} True if pending
3071 -=======
30722899 * @return \type{\bool}
3073 ->>>>>>> .r38752
30742900 */
30752901 function isEmailConfirmationPending() {
30762902 global $wgEmailAuthentication;
@@ -3129,13 +2955,8 @@
31302956 /**
31312957 * Get the localized descriptive name for a group, if it exists
31322958 *
3133 -<<<<<<< .mine
31342959 * @param $group \type{\string} Internal group name
3135 - * @return \type{\string} Localized descriptive group name
3136 -=======
3137 - * @param $group \type{\string} Internal group name
31382960 * @return \type{\string}
3139 ->>>>>>> .r38752
31402961 */
31412962 static function getGroupName( $group ) {
31422963 global $wgMessageCache;
@@ -3150,13 +2971,8 @@
31512972 /**
31522973 * Get the localized descriptive name for a member of a group, if it exists
31532974 *
3154 -<<<<<<< .mine
31552975 * @param $group \type{\string} Internal group name
3156 - * @return \type{\string} Localized name for group member
3157 -=======
3158 - * @param $group \type{\string} Internal group name
31592976 * @return \type{\string}
3160 ->>>>>>> .r38752
31612977 */
31622978 static function getGroupMember( $group ) {
31632979 global $wgMessageCache;
@@ -3172,7 +2988,7 @@
31732989 * Return the set of defined explicit groups.
31742990 * The implicit groups (by default *, 'user' and 'autoconfirmed')
31752991 * are not included, as they are defined automatically, not in the database.
3176 - * @return \arrayof{\string} Array of internal group names
 2992+ * @return \arrayof{\string}
31772993 */
31782994 static function getAllGroups() {
31792995 global $wgGroupPermissions;
@@ -3184,7 +3000,7 @@
31853001
31863002 /**
31873003 * Get a list of all available permissions.
3188 - * @return \arrayof{\string} Array of permission names
 3004+ * @return \arrayof{\string}
31893005 */
31903006 static function getAllRights() {
31913007 if ( self::$mAllRights === false ) {
@@ -3201,7 +3017,7 @@
32023018
32033019 /**
32043020 * Get a list of implicit groups
3205 - * @return \arrayof{\string} Array of internal group names
 3021+ * @return \arrayof{\string}
32063022 */
32073023 public static function getImplicitGroups() {
32083024 global $wgImplicitGroups;
@@ -3318,13 +3134,8 @@
33193135 /**
33203136 * Get the description of a given right
33213137 *
3322 -<<<<<<< .mine
33233138 * @param $right \type{\string} Right to query
3324 - * @return \type{\string} Localized description of the right
3325 -=======
3326 - * @param $right \type{\string} Right to query
33273139 * @return \type{\string}
3328 ->>>>>>> .r38752
33293140 */
33303141 static function getRightDescription( $right ) {
33313142 global $wgMessageCache;
@@ -3377,17 +3188,10 @@
33783189 * Compare a password hash with a plain-text password. Requires the user
33793190 * ID if there's a chance that the hash is an old-style hash.
33803191 *
3381 -<<<<<<< .mine
33823192 * @param $hash \type{\string} Password hash
33833193 * @param $password \type{\string} Plain-text password to compare
33843194 * @param $userId \type{\string} %User ID for old-style password salt
3385 - * @return \type{\bool} True if matches, false otherwise
3386 -=======
3387 - * @param $hash \type{\string} Password hash
3388 - * @param $password \type{\string} Plain-text password to compare
3389 - * @param $userId \type{\string} %User ID for old-style password salt
33903195 * @return \type{\bool}
3391 ->>>>>>> .r38752
33923196 */
33933197 static function comparePasswords( $hash, $password, $userId = false ) {
33943198 $m = false;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r38753Finishing touches on User.php documentationkrimpet08:22, 7 August 2008

Status & tagging log