r38754 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38753‎ | r38754 | r38755 >
Date:08:33, 7 August 2008
Author:mkroetzsch
Status:old
Tags:
Comment:
Fixed display of short code in Factbox
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_DV_String.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/SMW_DV_String.php
@@ -94,8 +94,6 @@
9595 */
9696 protected function getAbbValue($linked) {
9797 $len = mb_strlen($this->m_value);
98 - $starttag = ($this->m_typeid=='_cod')?'<pre>':'';
99 - $endtag = ($this->m_typeid=='_cod')?'</pre>':'';
10098 if ( ($len > 255) && ($this->m_typeid != '_cod') ) {
10199 if ( ($linked === NULL)||($linked === false) ) {
102100 return mb_substr($this->m_value, 0, 42) . ' <span class="smwwarning">&hellip;</span> ' . mb_substr($this->m_value, $len - 42);
@@ -103,7 +101,7 @@
104102 smwfRequireHeadItem(SMW_HEADER_TOOLTIP);
105103 return mb_substr($this->m_value, 0, 42) . ' <span class="smwttpersist"> &hellip; <span class="smwttcontent">' . $this->m_value . '</span></span> ' . mb_substr($this->m_value, $len - 42);
106104 }
107 - } elseif ($len > 255) {
 105+ } elseif ($this->m_typeid == '_cod') {
108106 return $this->getCodeDisplay($this->m_value,true);
109107 } else {
110108 return $this->m_value;

Status & tagging log