r38746 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38745‎ | r38746 | r38747 >
Date:23:43, 6 August 2008
Author:brion
Status:old
Tags:
Comment:
* (bug 15055) Talk page notifications no longer attempt to send mail when
user's e-mail address is invalid or unconfirmed
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/UserMailer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/UserMailer.php
@@ -347,9 +347,13 @@
348348 } elseif ( $targetUser->getId() == $editor->getId() ) {
349349 wfDebug( __METHOD__.": user edited their own talk page, no notification sent\n" );
350350 } elseif( $targetUser->getOption( 'enotifusertalkpages' ) ) {
351 - wfDebug( __METHOD__.": sending talk page update notification\n" );
352 - $this->compose( $targetUser );
353 - $userTalkId = $targetUser->getId();
 351+ if( $targetUser->isEmailConfirmed() ) {
 352+ wfDebug( __METHOD__.": sending talk page update notification\n" );
 353+ $this->compose( $targetUser );
 354+ $userTalkId = $targetUser->getId();
 355+ } else {
 356+ wfDebug( __METHOD__.": talk page owner doesn't have validated email\n" );
 357+ }
354358 } else {
355359 wfDebug( __METHOD__.": talk page owner doesn't want notifications\n" );
356360 }
Index: trunk/phase3/RELEASE-NOTES
@@ -66,8 +66,9 @@
6767 * (bug 15049) Fix for CheckUser extension's log search: usernames containing
6868 a "-" were incorrectly turned into bogus IP range searches.
6969 Patch by Max Semenik.
 70+* (bug 15055) Talk page notifications no longer attempt to send mail when
 71+ user's e-mail address is invalid or unconfirmed
7072
71 -
7273 === API changes in 1.14 ===
7374
7475 * Registration time of users registered before the DB field was created is now

Status & tagging log