r38738 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38737‎ | r38738 | r38739 >
Date:20:50, 6 August 2008
Author:ialex
Status:old
Tags:
Comment:
* Tweak for my last commit: parse -> parseinline
* Add bug no in RELEASE-NOTES
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialListgrouprights.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialListgrouprights.php
@@ -100,7 +100,7 @@
101101 $r = array();
102102 foreach( $permissions as $permission => $granted ) {
103103 if ( $granted ) {
104 - $description = wfMsgExt( 'listgrouprights-right-display', array( 'parse' ),
 104+ $description = wfMsgExt( 'listgrouprights-right-display', array( 'parseinline' ),
105105 User::getRightDescription( $permission ),
106106 $permission
107107 );
@@ -111,12 +111,12 @@
112112 if( $add === true ){
113113 $r[] = wfMsgExt( 'listgrouprights-addgroup-all', array( 'escape' ) );
114114 } else if( is_array( $add ) && count( $add ) ) {
115 - $r[] = wfMsgExt( 'listgrouprights-addgroup', array( 'parse' ), $wgLang->listToText( array_map( array( 'User', 'makeGroupLinkWiki' ), $add ) ), count( $add ) );
 115+ $r[] = wfMsgExt( 'listgrouprights-addgroup', array( 'parseinline' ), $wgLang->listToText( array_map( array( 'User', 'makeGroupLinkWiki' ), $add ) ), count( $add ) );
116116 }
117117 if( $remove === true ){
118118 $r[] = wfMsgExt( 'listgrouprights-removegroup-all', array( 'escape' ) );
119119 } else if( is_array( $remove ) && count( $remove ) ) {
120 - $r[] = wfMsgExt( 'listgrouprights-removegroup', array( 'parse' ), $wgLang->listToText( array_map( array( 'User', 'makeGroupLinkWiki' ), $remove ) ), count( $remove ) );
 120+ $r[] = wfMsgExt( 'listgrouprights-removegroup', array( 'parseinline' ), $wgLang->listToText( array_map( array( 'User', 'makeGroupLinkWiki' ), $remove ) ), count( $remove ) );
121121 }
122122 if( empty( $r ) ) {
123123 return '';
Index: trunk/phase3/RELEASE-NOTES
@@ -42,7 +42,8 @@
4343 sidebar and add custom portlets to it
4444 * Added 'MakeGlobalVariablesScript' hook for extensions to be able to add vari-
4545 ables into into the output of Skin::makeVariablesScript
46 -* Added $wgAddGroups and $wgRemoveGroups display on Special:ListGroupRights
 46+* (bug 13846) Added $wgAddGroups and $wgRemoveGroups display on
 47+ Special:ListGroupRights
4748 * (bug 14377) Add a date selector to history pages
4849 * (bug 15007) New 'pagetitle-view-mainpage' message allows the HTML <title> of
4950 the main page to be customized

Status & tagging log