r38727 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38726‎ | r38727 | r38728 >
Date:17:21, 6 August 2008
Author:ialex
Status:old
Tags:
Comment:
For compatibility with PHP 5.0, it does not accept array as param type
Modified paths:
  • /trunk/phase3/includes/Diff.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Diff.php
@@ -30,7 +30,7 @@
3131 *
3232 * @author Guy Van den Broeck
3333 */
34 -function wikidiff3_diff(array $from, array $to, $boundRunningTime=FALSE, $max_NP_before_bound = 800000){
 34+function wikidiff3_diff( /*array*/ $from, /*array*/ $to, $boundRunningTime=FALSE, $max_NP_before_bound = 800000){
3535 wfProfileIn( __METHOD__ );
3636
3737 $m = sizeof($from);
@@ -101,7 +101,7 @@
102102 return array($result_from, $result_to);
103103 }
104104
105 -function wikidiff3_diffPart(array $a, array $b, InLcs $a_inLcs, InLcs $b_inLcs, $m, $n, $offsetx, $offsety, $bestKnownLcs, $boundRunningTime=FALSE, $max_NP_before_bound = 800000){
 105+function wikidiff3_diffPart( /*array*/ $a, /*array*/ $b, InLcs $a_inLcs, InLcs $b_inLcs, $m, $n, $offsetx, $offsety, $bestKnownLcs, $boundRunningTime=FALSE, $max_NP_before_bound = 800000){
106106 if($bestKnownLcs==0 || $m==0 || $n==0){
107107 return;
108108 }

Status & tagging log