r38719 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38718‎ | r38719 | r38720 >
Date:15:59, 6 August 2008
Author:raymond
Status:old
Tags:
Comment:
Reapply part of r38229 under consideration of Brions revert comment (r38249):
* Add a nice fieldset for consistency with a better legend
* Switch result line and input form in kind that the hotspot for "Show new images since..." link does not change when following new uploads
Modified paths:
  • /trunk/phase3/includes/specials/SpecialNewimages.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -1986,6 +1986,8 @@
19871987 'newimages',
19881988 'imagelisttext',
19891989 'newimages-summary',
 1990+ 'newimages-legend',
 1991+ 'newimages-label',
19901992 'showhidebots',
19911993 'noimages',
19921994 'ilsubmit',
Index: trunk/phase3/includes/specials/SpecialNewimages.php
@@ -136,6 +136,19 @@
137137 $lastTimestamp = $timestamp;
138138 }
139139
 140+ $titleObj = SpecialPage::getTitleFor( 'Newimages' );
 141+ $action = $titleObj->getLocalURL( $hidebots ? '' : 'hidebots=0' );
 142+ if ( $shownav && !$wgMiserMode ) {
 143+ $wgOut->addHTML(
 144+ Xml::openElement( 'form', array( 'action' => $action, 'method' => 'post', 'id' => 'imagesearch' ) ) .
 145+ Xml::fieldset( wfMsg( 'newimages-legend' ) ) .
 146+ Xml::inputLabel( wfMsg( 'newimages-label' ), 'wpIlMatch', 'wpIlMatch', 20, $wpIlMatch ) . ' ' .
 147+ Xml::submitButton( wfMsg( 'ilsubmit' ), array( 'name' => 'wpIlSubmit' ) ) .
 148+ Xml::closeElement( 'fieldset' ) .
 149+ Xml::closeElement( 'form' )
 150+ );
 151+ }
 152+
140153 $bydate = wfMsg( 'bydate' );
141154 $lt = $wgLang->formatNum( min( $shownImages, $limit ) );
142155 if ( $shownav ) {
@@ -143,17 +156,6 @@
144157 $wgOut->addHTML( $text . "\n" );
145158 }
146159
147 - $sub = wfMsg( 'ilsubmit' );
148 - $titleObj = SpecialPage::getTitleFor( 'Newimages' );
149 - $action = $titleObj->escapeLocalURL( $hidebots ? '' : 'hidebots=0' );
150 - if ($shownav && !$wgMiserMode) {
151 - $wgOut->addHTML( "<form id=\"imagesearch\" method=\"post\" action=\"" .
152 - "{$action}\">" .
153 - Xml::input( 'wpIlMatch', 20, $wpIlMatch ) . ' ' .
154 - Xml::submitButton( $sub, array( 'name' => 'wpIlSubmit' ) ) .
155 - "</form>" );
156 - }
157 -
158160 /**
159161 * Paging controls...
160162 */
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2819,6 +2819,8 @@
28202820 'newimages' => 'Gallery of new files',
28212821 'imagelisttext' => "Below is a list of '''$1''' {{PLURAL:$1|file|files}} sorted $2.",
28222822 'newimages-summary' => 'This special page shows the last uploaded files.',
 2823+'newimages-legend' => 'Filter',
 2824+'newimages-label' => 'Filename (or a part of it):',
28232825 'showhidebots' => '($1 bots)',
28242826 'noimages' => 'Nothing to see.',
28252827 'ilsubmit' => 'Search',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r38229* Add a nice fieldset for consistency...raymond11:29, 30 July 2008
r38249Revert r38229:...brion19:55, 30 July 2008

Status & tagging log