r38708 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38707‎ | r38708 | r38709 >
Date:12:59, 6 August 2008
Author:raymond
Status:old
Tags:
Comment:
Switch errormessage and filter to show 1) filters and 2) errormessage.
Otherwise the filter hops around.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialWhatlinkshere.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialWhatlinkshere.php
@@ -167,11 +167,13 @@
168168 if( ( !$fetchlinks || !$dbr->numRows($plRes) ) && ( $hidetrans || !$dbr->numRows($tlRes) ) && ( $hideimages || !$dbr->numRows($ilRes) ) ) {
169169 if ( 0 == $level ) {
170170 $wgOut->addHTML( $this->whatlinkshereForm() );
171 - $errMsg = is_int($namespace) ? 'nolinkshere-ns' : 'nolinkshere';
172 - $wgOut->addWikiMsg( $errMsg, $this->target->getPrefixedText() );
 171+
173172 // Show filters only if there are links
174173 if( $hidelinks || $hidetrans || $hideredirs || $hideimages )
175174 $wgOut->addHTML( $this->getFilterPanel() );
 175+
 176+ $errMsg = is_int($namespace) ? 'nolinkshere-ns' : 'nolinkshere';
 177+ $wgOut->addWikiMsg( $errMsg, $this->target->getPrefixedText() );
176178 }
177179 return;
178180 }

Status & tagging log