r38704 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r38703‎ | r38704 | r38705 >
Date:10:57, 6 August 2008
Author:nikerabbit
Status:old
Tags:
Comment:
* Revert r38702
Warning: array_splice() [function.array-splice]: The first argument should be an array in /var/www/sandwiki/extensions/Translate/TranslateEditAddons.php on line 263
Warning: Missing argument 2 for wfMsgExt() in /var/www/sandwiki/includes/GlobalFunctions.php on line 613
Notice: Undefined variable: options in /var/www/sandwiki/includes/GlobalFunctions.php on line 620
Notice: Undefined variable: options in /var/www/sandwiki/includes/GlobalFunctions.php on line 621
Modified paths:
  • /trunk/extensions/Translate/MessageChecks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/MessageChecks.php
——@@ -57,7 +57,7 @@
5858
5959 foreach ( $this->checksForType[$type] as $check ) {
6060 $warning = '';
61 - if ( call_user_func( array($this, $check), $message, $code, $warning ) ) {
 61+ if ( call_user_func( array($this, $check), $message, $code, &$warning ) ) {
6262 $warnings[] = $warning;
6363 }
6464 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r38702Removing call-time pass-by-reference: Seems unnecessary, and shows a warning.rotem10:49, 6 August 2008

Status & tagging log