r38621 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38620‎ | r38621 | r38622 >
Date:10:40, 5 August 2008
Author:raymond
Status:old
Tags:
Comment:
Allow PLURAL for 'listgrouprights-addgroup' and 'listgrouprights-removegroup'
Modified paths:
  • /trunk/phase3/includes/specials/SpecialListgrouprights.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialListgrouprights.php
@@ -109,14 +109,14 @@
110110 }
111111 sort( $r );
112112 if( $add === true ){
113 - $r[] = wfMsgHTML( 'listgrouprights-addgroup-all' );
 113+ $r[] = wfMsgExt( 'listgrouprights-addgroup-all', array( 'escape' ) );
114114 } else if( is_array( $add ) && count( $add ) ) {
115 - $r[] = wfMsgHTML( 'listgrouprights-addgroup', $wgLang->listToText( $add ) );
 115+ $r[] = wfMsgExt( 'listgrouprights-addgroup', array( 'parsemag', 'escape' ), $wgLang->listToText( $add ), count( $add ) );
116116 }
117117 if( $remove === true ){
118 - $r[] = wfMsgHTML( 'listgrouprights-removegroup-all' );
 118+ $r[] = wfMsgExt( 'listgrouprights-removegroup-all', array( 'escape' ) );
119119 } else if( is_array( $remove ) && count( $remove ) ) {
120 - $r[] = wfMsgHTML( 'listgrouprights-removegroup', $wgLang->listToText( $remove ) );
 120+ $r[] = wfMsgExt( 'listgrouprights-removegroup', array( 'parsemag', 'escape' ), $wgLang->listToText( $remove ), count( $remove ) );
121121 }
122122 if( empty( $r ) ) {
123123 return '';
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2026,8 +2026,8 @@
20272027 'listgrouprights-helppage' => 'Help:Group rights',
20282028 'listgrouprights-members' => '(list of members)',
20292029 'listgrouprights-right-display' => '$1 ($2)', # only translate this message to other languages if you have to change it
2030 -'listgrouprights-addgroup' => 'Can add groups: $1',
2031 -'listgrouprights-removegroup' => 'Can remove groups: $1',
 2030+'listgrouprights-addgroup' => 'Can add {{PLURAL:$2|group|groups}}: $1',
 2031+'listgrouprights-removegroup' => 'Can remove {{PLURAL:$2|group|groups}}: $1',
20322032 'listgrouprights-addgroup-all' => 'Can add all groups',
20332033 'listgrouprights-removegroup-all' => 'Can remove all groups',
20342034

Status & tagging log