r38612 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38611‎ | r38612 | r38613 >
Date:05:12, 5 August 2008
Author:brion
Status:old
Tags:
Comment:
Update for r38533 -- avoid notice spew from groups that have no record for the perm
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -2778,7 +2778,7 @@
27792779 global $wgGroupPermissions;
27802780 $allowedGroups = array();
27812781 foreach ( $wgGroupPermissions as $group => $rights ) {
2782 - if ( $rights[$role] === true ) {
 2782+ if ( isset( $rights[$role] ) && $rights[$role] ) {
27832783 $allowedGroups[] = $group;
27842784 }
27852785 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r38533Reimplement User::, now with less crappy name and only taking one permission ...demon05:14, 4 August 2008

Status & tagging log