r38532 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38531‎ | r38532 | r38533 >
Date:05:07, 4 August 2008
Author:midom
Status:old
Tags:
Comment:
add some useless WHERE condition instead of 'Job::pop' :)
Modified paths:
  • /trunk/phase3/includes/JobQueue.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/JobQueue.php
@@ -127,7 +127,7 @@
128128 // Failed, someone else beat us to it
129129 // Try getting a random row
130130 $row = $dbw->selectRow( 'job', array( 'MIN(job_id) as minjob',
131 - 'MAX(job_id) as maxjob' ), __METHOD__ );
 131+ 'MAX(job_id) as maxjob' ), '1=1', __METHOD__ );
132132 if ( $row === false || is_null( $row->minjob ) || is_null( $row->maxjob ) ) {
133133 // No jobs to get
134134 wfProfileOut( __METHOD__ );

Status & tagging log