r38372 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38371‎ | r38372 | r38373 >
Date:15:50, 1 August 2008
Author:dantman
Status:old
Tags:
Comment:
Bugfix... PHP Notice outputted cause $skin was used in hook instead of $this.
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -1715,7 +1715,7 @@
17161716 } else { continue; }
17171717 }
17181718 }
1719 - wfRunHooks('SkinBuildSidebar', array($skin, &$bar));
 1719+ wfRunHooks('SkinBuildSidebar', array($this, &$bar));
17201720 if ( $wgEnableSidebarCache ) $parserMemc->set( $key, $bar, $wgSidebarCacheExpiry );
17211721 wfProfileOut( __METHOD__ );
17221722 return $bar;

Status & tagging log