r38331 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38330‎ | r38331 | r38332 >
Date:02:02, 1 August 2008
Author:brion
Status:old
Tags:
Comment:
Fix regression from r38325 -- caused first character of section name in a history link to be trimmed.
Title::setFragment() does not do what you'd think it does. :)
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
@@ -1233,7 +1233,7 @@
12341234 $sectionTitle = Title::newFromText( '#' . $section );
12351235 } else {
12361236 $sectionTitle = wfClone( $title );
1237 - $sectionTitle->setFragment( $section );
 1237+ $sectionTitle->mFragment = $section;
12381238 }
12391239 $link = $this->link( $sectionTitle, wfMsgForContent( 'sectionlink' ) );
12401240 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r38325(bug 14995) Some link fragments in the interface stopped appearing, because T...simetrical00:47, 1 August 2008

Status & tagging log