r38319 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38318‎ | r38319 | r38320 >
Date:22:06, 31 July 2008
Author:demon
Status:old
Tags:
Comment:
Not setting various parameters no longer causes the ForeignAPIRepo to fail horribly. Thanks to Siebrand for pointing it out.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/filerepo/FileRepo.php (modified) (history)
  • /trunk/phase3/includes/filerepo/ForeignAPIFile.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/FileRepo.php
@@ -15,6 +15,7 @@
1616 var $thumbScriptUrl, $transformVia404;
1717 var $descBaseUrl, $scriptDirUrl, $articleUrl, $fetchDescription, $initialCapital;
1818 var $pathDisclosureProtection = 'paranoid';
 19+ var $descriptionCacheExpiry, $apiThumbCacheExpiry, $apiThumbCacheDir;
1920
2021 /**
2122 * Factory functions for creating new files
Index: trunk/phase3/includes/filerepo/ForeignAPIFile.php
@@ -31,7 +31,7 @@
3232 }
3333
3434 function transform( $params, $flags = 0 ) {
35 - if ( $this->repo->apiThumbCacheExpiry > 0 ) {
 35+ if ( $this->repo->apiThumbCacheExpiry > 0 && $this->repo->apiThumbCacheDir ) {
3636 $thumbUrl = $this->repo->getThumbUrlFromCache(
3737 $this->getName(),
3838 isset( $params['width'] ) ? $params['width'] : -1,
Index: trunk/phase3/RELEASE-NOTES
@@ -47,6 +47,7 @@
4848 * (bug 14954) Fix regression in Modern and Simple skins
4949 * Recursion loop check added to Categoryfinder class
5050 * Fixed few performance troubles of large job queue processing
 51+* Not setting various parameters in Foreign Repos now fails more gracefully
5152
5253 === API changes in 1.14 ===
5354

Status & tagging log