r38278 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38277‎ | r38278 | r38279 >
Date:07:40, 31 July 2008
Author:aaron
Status:old
Tags:
Comment:
Some fixes for move autosighting (bug 14984)
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.class.php
@@ -1697,14 +1697,14 @@
16981698 if( !$baseRevID ) {
16991699 $baseRevID = $wgRequest->getIntOrNull('baseRevId');
17001700 }
 1701+ $title->resetArticleID( $rev->getPage() ); // avoid db hit
17011702 # Get what was just the current revision ID
1702 - $prevRevID = $title->getPreviousRevisionId( $rev->getId(), GAID_FOR_UPDATE );
 1703+ $prevRevID = $title->getPreviousRevisionId( $rev->getId() );
17031704 // New pages
17041705 if( !$prevRevID ) {
17051706 $reviewableNewPage = ( $wgFlaggedRevsAutoReviewNew && $user->isAllowed('review') );
17061707 // Edits to existing pages
17071708 } else if( $baseRevID ) {
1708 - $title->resetArticleID( $rev->getPage() ); // avoid db hit
17091709 $frev = FlaggedRevision::newFromTitle( $title, $baseRevID, FR_FOR_UPDATE );
17101710 # If the base revision was not reviewed, check if the previous one was.
17111711 # This should catch null edits as well as normal ones.

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r38277set baserevid (part of bug 14984)aaron07:39, 31 July 2008

Status & tagging log