r38265 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38264‎ | r38265 | r38266 >
Date:23:41, 30 July 2008
Author:jhsoby
Status:old
Tags:
Comment:
Adding accesskey="s" to forms in the following special pages:
* Special:BlockIP
* Special:EmailUser
* Special:ExpandTemplates
* Special:Export
* Special:Import
* Special:ParserDiffTest
* Special:UserRights
Modified paths:
  • /trunk/extensions/ExpandTemplates/ExpandTemplates_body.php (modified) (history)
  • /trunk/extensions/ParserDiffTest/ParserDiffTest_body.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialBlockip.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialEmailuser.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialExport.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialImport.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUserrights.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserrights.php
@@ -384,7 +384,7 @@
385385 <tr>
386386 <td></td>
387387 <td class='mw-submit'>" .
388 - Xml::submitButton( wfMsg( 'saveusergroups' ), array( 'name' => 'saveusergroups' ) ) .
 388+ Xml::submitButton( wfMsg( 'saveusergroups' ), array( 'name' => 'saveusergroups', 'accesskey' => 's' ) ) .
389389 "</td>
390390 </tr>" .
391391 Xml::closeElement( 'table' ) . "\n" .
Index: trunk/phase3/includes/specials/SpecialImport.php
@@ -159,7 +159,7 @@
160160 <td>
161161 </td>
162162 <td>" .
163 - Xml::submitButton( wfMsg( 'import-interwiki-submit' ) ) .
 163+ Xml::submitButton( wfMsg( 'import-interwiki-submit' ), array( 'accesskey' = 's' ) ) .
164164 "</td>
165165 </tr>" .
166166 Xml::closeElement( 'table' ).
Index: trunk/phase3/includes/specials/SpecialExport.php
@@ -278,7 +278,7 @@
279279 //$form .= Xml::checkLabel( wfMsg( 'export-images' ), 'images', 'wpExportImages', false ) . '<br />';
280280 $form .= Xml::checkLabel( wfMsg( 'export-download' ), 'wpDownload', 'wpDownload', true ) . '<br />';
281281
282 - $form .= Xml::submitButton( wfMsg( 'export-submit' ) );
 282+ $form .= Xml::submitButton( wfMsg( 'export-submit' ), array( 'accesskey' => 's' ) );
283283 $form .= Xml::closeElement( 'form' );
284284 $wgOut->addHtml( $form );
285285 }
Index: trunk/phase3/includes/specials/SpecialBlockip.php
@@ -246,7 +246,7 @@
247247 <td style='padding-top: 1em'>&nbsp;</td>
248248 <td class='mw-submit' style='padding-top: 1em'>" .
249249 Xml::submitButton( wfMsg( 'ipbsubmit' ),
250 - array( 'name' => 'wpBlock', 'tabindex' => '12' ) ) . "
 250+ array( 'name' => 'wpBlock', 'tabindex' => '12', 'accesskey' => 's' ) ) . "
251251 </td>
252252 </tr>" .
253253 Xml::closeElement( 'table' ) .
Index: trunk/phase3/includes/specials/SpecialEmailuser.php
@@ -130,7 +130,7 @@
131131 <textarea id=\"wpText\" name=\"wpText\" rows='20' cols='80' style=\"width: 100%;\">" . htmlspecialchars( $this->text ) .
132132 "</textarea>
133133 " . wfCheckLabel( $emc, 'wpCCMe', 'wpCCMe', $wgUser->getBoolOption( 'ccmeonemails' ) ) . "<br />
134 -<input type='submit' name=\"wpSend\" value=\"{$ems}\" />
 134+<input type='submit' name=\"wpSend\" value=\"{$ems}\" accesskey=\"s\" />
135135 <input type='hidden' name='wpEditToken' value=\"$token\" />
136136 </form>\n" );
137137
Index: trunk/extensions/ParserDiffTest/ParserDiffTest_body.php
@@ -126,7 +126,7 @@
127127 $form .= Xml::openElement( 'textarea', array( 'name' => 'pdt_input', 'id' => 'pdt_input', 'rows' => 10, 'cols' => 10 ) );
128128 $form .= htmlspecialchars( $text );
129129 $form .= Xml::closeElement( 'textarea' );
130 - $form .= '<p>' . Xml::submitButton( wfMsg( 'pdtest_ok' ) ) . '&nbsp;&nbsp;' .
 130+ $form .= '<p>' . Xml::submitButton( wfMsg( 'pdtest_ok' ), array( 'accesskey' => 's' ) ) . '&nbsp;&nbsp;' .
131131 Xml::submitButton( wfMsg( 'pdtest_get_text' ), array( 'name' => 'pdt_get_text' ) ) . '</p>';
132132 $form .= "</fieldset>\n";
133133 $form .= Xml::closeElement( 'form' );
Index: trunk/extensions/ExpandTemplates/ExpandTemplates_body.php
@@ -81,7 +81,7 @@
8282 if ( $this->isNewParser ) {
8383 $form .= '<p>' . Xml::checkLabel( wfMsg( 'expand_templates_generate_xml' ), 'generate_xml', 'generate_xml', $this->generateXML ) . '</p>';
8484 }
85 - $form .= '<p>' . Xml::submitButton( wfMsg( 'expand_templates_ok' ) ) . '</p>';
 85+ $form .= '<p>' . Xml::submitButton( wfMsg( 'expand_templates_ok' ), array( 'accesskey' => 's' ) ) . '</p>';
8686 $form .= "</fieldset>\n";
8787 $form .= Xml::closeElement( 'form' );
8888 return $form;

Status & tagging log