| Index: branches/REL1_13/phase3/includes/SearchEngine.php |
| — | — | @@ -290,6 +290,8 @@ |
| 291 | 291 | * Load up the appropriate search engine class for the currently |
| 292 | 292 | * active database backend, and return a configured instance. |
| 293 | 293 | * |
| | 294 | + * @fixme Ask the database class for his default search class |
| | 295 | + * instead of knowing about every backend here. |
| 294 | 296 | * @return SearchEngine |
| 295 | 297 | */ |
| 296 | 298 | public static function create() { |
| — | — | @@ -494,6 +496,9 @@ |
| 495 | 497 | |
| 496 | 498 | |
| 497 | 499 | /** |
| | 500 | + * @fixme This class is horribly factored. It would probably be better to have |
| | 501 | + * a useful base class to which you pass some standard information, then let |
| | 502 | + * the fancy self-highlighters extend that. |
| 498 | 503 | * @ingroup Search |
| 499 | 504 | */ |
| 500 | 505 | class SearchResult { |
| — | — | @@ -1139,16 +1144,11 @@ |
| 1140 | 1145 | } |
| 1141 | 1146 | |
| 1142 | 1147 | /** |
| | 1148 | + * Dummy class to be used when non-supported Database engine is present. |
| | 1149 | + * @fixme Dummy class should probably try something at least mildly useful, |
| | 1150 | + * such as a LIKE search through titles. |
| 1143 | 1151 | * @ingroup Search |
| 1144 | 1152 | */ |
| 1145 | | -class SearchEngineDummy { |
| 1146 | | - function search( $term ) { |
| 1147 | | - return null; |
| 1148 | | - } |
| 1149 | | - function setLimitOffset($l, $o) {} |
| 1150 | | - function legalSearchChars() {} |
| 1151 | | - function update() {} |
| 1152 | | - function setnamespaces() {} |
| 1153 | | - function searchtitle() {} |
| 1154 | | - function searchtext() {} |
| | 1153 | +class SearchEngineDummy extends SearchEngine { |
| | 1154 | + // no-op |
| 1155 | 1155 | } |
| Index: branches/REL1_13/phase3/RELEASE-NOTES |
| — | — | @@ -454,6 +454,8 @@ |
| 455 | 455 | * The accesskey to edit a page is now disabled when editing the page, to pre- |
| 456 | 456 | vent conflicts with Safari shortcuts. |
| 457 | 457 | * (bug 14907) DatabasePostgres::fieldType now defined. |
| | 458 | +* (bug 14966) Fix SearchEngineDummy class for silently non-functional search |
| | 459 | + on Sqlite instead of horribly fatal error breaky one. |
| 458 | 460 | |
| 459 | 461 | === API changes in 1.13 === |
| 460 | 462 | |