r38143 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38142‎ | r38143 | r38144 >
Date:19:09, 28 July 2008
Author:brion
Status:old
Tags:
Comment:
* (bug 14954) Fix regression in Modern and Simple skins

Earlier r38139 patched up Modern, but didn't address Simple.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/Simple.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Simple.php
@@ -23,7 +23,9 @@
2424 $this->skinname = 'simple';
2525 $this->stylename = 'simple';
2626 $this->template = 'MonoBookTemplate';
27 - $this->cssfiles = array( 'rtl' );
 27+ $this->addStyle( 'simple/main.css', 'screen' );
 28+ $this->addStyle( 'simple/rtl.css', '', '', 'rtl' );
 29+
2830 }
2931
3032 function reallyDoGetUserStyles() {
Index: trunk/phase3/RELEASE-NOTES
@@ -28,12 +28,14 @@
2929
3030 * (bug 8068) New __INDEX__ and __NOINDEX__ magic words allow user control of
3131 search engine indexing on a per-article basis.
 32+* Handheld stylesheet options
3233
3334 === Bug fixes in 1.14 ===
3435
3536 * (bug 14907) DatabasePostgres::fieldType now defined.
3637 * (bug 14659) Passing the default limit param to Special:Recentchanges no more
3738 falls back to the user option
 39+* (bug 14954) Fix regression in Modern and Simple skins
3840
3941 === API changes in 1.14 ===
4042

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r38139Some tweaks for r38116:...ialex16:54, 28 July 2008

Status & tagging log