r38039 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38038‎ | r38039 | r38040 >
Date:18:06, 25 July 2008
Author:ialex
Status:old
Tags:
Comment:
Per r38036: also fix FormOptions
Modified paths:
  • /trunk/phase3/includes/FormOptions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/FormOptions.php
@@ -176,8 +176,8 @@
177177 throw new MWException( 'Unsupported datatype' );
178178 }
179179
180 - if ( $value !== $default && $value !== null ) {
181 - $this->options[$name]['value'] = $value;
 180+ if ( $value !== null ) {
 181+ $this->options[$name]['value'] = $value === $default ? null : $value;
182182 }
183183 }
184184 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r38036(bug 14659) Passing the default limit param to Special:Recentchanges no more ...ialex16:46, 25 July 2008

Status & tagging log