r37994 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r37993‎ | r37994 | r37995 >
Date:12:37, 24 July 2008
Author:demon
Status:old
Tags:
Comment:
bug 14907 - DatabasePostgres::fieldType() wasn't defined, fatal errors abound.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/db/DatabasePostgres.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabasePostgres.php
@@ -1167,6 +1167,16 @@
11681168 function fieldInfo( $table, $field ) {
11691169 return PostgresField::fromText($this, $table, $field);
11701170 }
 1171+
 1172+ /**
 1173+ * pg_field_type() wrapper
 1174+ */
 1175+ function fieldType( $res, $index ) {
 1176+ if ( $res instanceof ResultWrapper ) {
 1177+ $res = $res->result;
 1178+ }
 1179+ return pg_field_type( $res, $index );
 1180+ }
11711181
11721182 function begin( $fname = 'DatabasePostgres::begin' ) {
11731183 $this->query( 'BEGIN', $fname );
Index: trunk/phase3/RELEASE-NOTES
@@ -29,7 +29,7 @@
3030
3131 === Bug fixes in 1.14 ===
3232
33 -None yet
 33+* (bug 14907) DatabasePostgres::fieldType now defined.
3434
3535 === API changes in 1.14 ===
3636

Follow-up revisions

RevisionCommit summaryAuthorDate
r37995Fix bug 14907 on branch as well.demon12:42, 24 July 2008

Status & tagging log