r37971 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r37970‎ | r37971 | r37972 >
Date:19:33, 23 July 2008
Author:simetrical
Status:old
Tags:
Comment:
Follow-up to r37968: forgot to commit the change setRobotpolicy -> setRobotPolicy in extensions. (Not committing lots of other stuff this time.)
Modified paths:
  • /trunk/extensions/AbuseFilter/SpecialAbuseFilter.php (modified) (history)
  • /trunk/extensions/AbuseFilter/SpecialAbuseLog.php (modified) (history)
  • /trunk/extensions/AssertEdit/AssertEdit.php (modified) (history)
  • /trunk/extensions/CentralAuth/SpecialGlobalGroupPermissions.php (modified) (history)
  • /trunk/extensions/EditUser/EditUser_body.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedArticle.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/specialpages/Stabilization_body.php (modified) (history)
  • /trunk/extensions/GlobalBlocking/SpecialGlobalBlock.php (modified) (history)
  • /trunk/extensions/GlobalBlocking/SpecialGlobalBlockList.php (modified) (history)
  • /trunk/extensions/ImageTagging/ImageTagging_body.php (modified) (history)
  • /trunk/extensions/Invitations/Invitations_page.php (modified) (history)
  • /trunk/extensions/LatexDoc/LatexDoc.php (modified) (history)
  • /trunk/extensions/LuceneSearch/LuceneSearch_body.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_EditPageAjax.php (modified) (history)
  • /trunk/extensions/OpenID/SpecialOpenIDConvert.body.php (modified) (history)
  • /trunk/extensions/OpenID/SpecialOpenIDFinish.body.php (modified) (history)
  • /trunk/extensions/OpenID/SpecialOpenIDLogin.body.php (modified) (history)
  • /trunk/extensions/Player/SpecialPlayer.php (modified) (history)
  • /trunk/extensions/Postcomment/SpecialPostcomment.php (modified) (history)
  • /trunk/extensions/SemanticForms/specials/SF_UploadWindow.php (modified) (history)
  • /trunk/extensions/experimental/SpecialValidate.php (modified) (history)
  • /trunk/extensions/gis/maparea.php (modified) (history)
  • /trunk/extensions/gis/mapsources.php (modified) (history)
  • /trunk/extensions/gis/neighbors.php (modified) (history)
  • /trunk/extensions/wikiwyg/share/MediaWiki/extensions/EZParser.php (modified) (history)
  • /trunk/extensions/wikiwyg/share/MediaWiki/extensions/MediaWikiWyg.php (modified) (history)

Diff [purge]

Index: trunk/extensions/gis/neighbors.php
——@@ -52,7 +52,7 @@
5353 global $wgOut, $wgUser, $wgContLang;
5454
5555 /* No reason for robots to follow these links */
56 - $wgOut->setRobotpolicy( 'noindex,nofollow' );
 56+ $wgOut->setRobotPolicy( 'noindex,nofollow' );
5757
5858 $wgOut->setPagetitle( "Neighbors" );
5959
Index: trunk/extensions/gis/mapsources.php
——@@ -51,7 +51,7 @@
5252 global $wgOut;
5353
5454 /* No reason for robots to follow map links */
55 - $wgOut->setRobotpolicy( 'noindex,nofollow' );
 55+ $wgOut->setRobotPolicy( 'noindex,nofollow' );
5656
5757 $wgOut->setPagetitle( $this->mapsources );
5858 $wgOut->addWikiText( $this->build_output() );
Index: trunk/extensions/gis/maparea.php
——@@ -46,7 +46,7 @@
4747
4848 if ($action != 'raw') {
4949 /* No reason for robots to follow map links */
50 - $wgOut->setRobotpolicy( 'noindex,nofollow' );
 50+ $wgOut->setRobotPolicy( 'noindex,nofollow' );
5151
5252 $wgOut->setPagetitle( "Maparea" );
5353
Index: trunk/extensions/experimental/SpecialValidate.php
——@@ -564,7 +564,7 @@
565565 if( $wgUseValidation ) {
566566 require_once ( 'SpecialValidate.php' ) ;
567567 $wgOut->setPagetitle( wfMsg( 'validate' ) . ': ' . $this->mTitle->getPrefixedText() );
568 - $wgOut->setRobotpolicy( 'noindex,follow' );
 568+ $wgOut->setRobotPolicy( 'noindex,follow' );
569569 if( $this->mTitle->getNamespace() != 0 ) {
570570 $wgOut->addHTML( wfMsg( 'val_validate_article_namespace_only' ) );
571571 return;
Index: trunk/extensions/GlobalBlocking/SpecialGlobalBlock.php
——@@ -15,7 +15,7 @@
1616 $this->loadParameters();
1717
1818 $wgOut->setPageTitle( wfMsg( 'globalblocking-block' ) );
19 - $wgOut->setRobotpolicy( "noindex,nofollow" );
 19+ $wgOut->setRobotPolicy( "noindex,nofollow" );
2020 $wgOut->setArticleRelated( false );
2121 $wgOut->enableClientCache( false );
2222
Index: trunk/extensions/GlobalBlocking/SpecialGlobalBlockList.php
——@@ -15,7 +15,7 @@
1616 $this->loadParameters();
1717
1818 $wgOut->setPageTitle( wfMsg( 'globalblocking-list' ) );
19 - $wgOut->setRobotpolicy( "noindex,nofollow" );
 19+ $wgOut->setRobotPolicy( "noindex,nofollow" );
2020 $wgOut->setArticleRelated( false );
2121 $wgOut->enableClientCache( false );
2222
Index: trunk/extensions/SemanticForms/specials/SF_UploadWindow.php
——@@ -1493,7 +1493,7 @@
14941494 function showError( $description ) {
14951495 global $wgOut;
14961496 $wgOut->setPageTitle( wfMsg( "internalerror" ) );
1497 - $wgOut->setRobotpolicy( "noindex,nofollow" );
 1497+ $wgOut->setRobotPolicy( "noindex,nofollow" );
14981498 $wgOut->setArticleRelated( false );
14991499 $wgOut->enableClientCache( false );
15001500 $wgOut->addWikiText( $description );
Index: trunk/extensions/LatexDoc/LatexDoc.php
——@@ -57,7 +57,7 @@
5858
5959 $wgOut->setArticleFlag( false );
6060 $wgOut->setArticleRelated( true );
61 - $wgOut->setRobotpolicy( 'noindex,nofollow' );
 61+ $wgOut->setRobotPolicy( 'noindex,nofollow' );
6262 $wgOut->setPageTitle( $article->mTitle->getPrefixedText() );
6363
6464 if ( $ext == 'pdf' ) {
Index: trunk/extensions/EditUser/EditUser_body.php
——@@ -510,7 +510,7 @@
511511
512512 $wgOut->setPageTitle( wfMsg( 'edituser' ) );
513513 $wgOut->setArticleRelated( false );
514 - $wgOut->setRobotpolicy( 'noindex,nofollow' );
 514+ $wgOut->setRobotPolicy( 'noindex,nofollow' );
515515
516516 $wgOut->disallowUserJs(); # Prevent hijacked user scripts from sniffing passwords etc.
517517
Index: trunk/extensions/LuceneSearch/LuceneSearch_body.php
——@@ -277,7 +277,7 @@
278278 if( isset( $prevnext ) ) $wgOut->addHTML('<hr />' . $prevnext);
279279 $wgOut->addHTML($this->showFullDialog($q));
280280 }
281 - $wgOut->setRobotpolicy('noindex,nofollow');
 281+ $wgOut->setRobotPolicy('noindex,nofollow');
282282 $wgOut->setArticleRelated(false);
283283 wfProfileOut( $fname );
284284 }
Index: trunk/extensions/CentralAuth/SpecialGlobalGroupPermissions.php
——@@ -52,7 +52,7 @@
5353 }
5454
5555 $wgOut->setPageTitle( wfMsg( 'globalgrouppermissions' ) );
56 - $wgOut->setRobotpolicy( "noindex,nofollow" );
 56+ $wgOut->setRobotPolicy( "noindex,nofollow" );
5757 $wgOut->setArticleRelated( false );
5858 $wgOut->enableClientCache( false );
5959
Index: trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_EditPageAjax.php
——@@ -418,7 +418,7 @@
419419
420420 //wfRunHooks( 'EditPage::showEditForm:initial', array( &$this ) ) ;
421421
422 - //$wgOut->setRobotpolicy( 'noindex,nofollow' );
 422+ //$wgOut->setRobotPolicy( 'noindex,nofollow' );
423423
424424 # Enabled article-related sidebar, top links, etc.
425425 $wgOut->setArticleRelated( true );
Index: trunk/extensions/ImageTagging/ImageTagging_body.php
——@@ -73,7 +73,7 @@
7474 $db->freeResult($res);
7575
7676 $wgOut->setPageTitle( wfMsg('imagetagging-taggedimages-title', $this->mQuery ? $this->mQuery : "all" ) );
77 - $wgOut->setRobotpolicy('noindex,nofollow');
 77+ $wgOut->setRobotPolicy('noindex,nofollow');
7878 $wgOut->addHTML($this->toHTML());
7979
8080 wfProfileOut( __METHOD__ );
Index: trunk/extensions/FlaggedRevs/FlaggedArticle.php
——@@ -265,7 +265,7 @@
266266 $wgOut->setRevisionId( $frev->getRevId() );
267267 $notes = $this->getReviewNotes( $frev );
268268 # Index the stable version only
269 - $wgOut->setRobotpolicy( 'noindex,nofollow' );
 269+ $wgOut->setRobotPolicy( 'noindex,nofollow' );
270270 # Tell MW that parser output is done
271271 $outputDone = true;
272272 $pcache = false;
——@@ -331,7 +331,7 @@
332332 }
333333 # Index the stable version only if it is the default
334334 if( $this->showStableByDefault() ) {
335 - $wgOut->setRobotpolicy( 'noindex,nofollow' );
 335+ $wgOut->setRobotPolicy( 'noindex,nofollow' );
336336 }
337337 // The relevant conditions are met to override the page with the stable version.
338338 } else {
Index: trunk/extensions/FlaggedRevs/specialpages/Stabilization_body.php
——@@ -82,7 +82,7 @@
8383 function showSettings( $err = null ) {
8484 global $wgOut, $wgTitle, $wgUser;
8585
86 - $wgOut->setRobotpolicy( 'noindex,nofollow' );
 86+ $wgOut->setRobotPolicy( 'noindex,nofollow' );
8787 # Must be a content page
8888 if( !FlaggedRevs::isPageReviewable( $this->page ) ) {
8989 $wgOut->addHTML( wfMsgExt('stableversions-none', array('parse'), $this->page->getPrefixedText() ) );
Index: trunk/extensions/AbuseFilter/SpecialAbuseLog.php
——@@ -16,7 +16,7 @@
1717 $this->loadParameters();
1818
1919 $wgOut->setPageTitle( wfMsg( 'abusefilter-log' ) );
20 - $wgOut->setRobotpolicy( "noindex,nofollow" );
 20+ $wgOut->setRobotPolicy( "noindex,nofollow" );
2121 $wgOut->setArticleRelated( false );
2222 $wgOut->enableClientCache( false );
2323
Index: trunk/extensions/AbuseFilter/SpecialAbuseFilter.php
——@@ -18,7 +18,7 @@
1919
2020 $this->loadParameters( $subpage );
2121 $wgOut->setPageTitle( wfMsg( 'abusefilter-management' ) );
22 - $wgOut->setRobotpolicy( "noindex,nofollow" );
 22+ $wgOut->setRobotPolicy( "noindex,nofollow" );
2323 $wgOut->setArticleRelated( false );
2424 $wgOut->enableClientCache( false );
2525
Index: trunk/extensions/wikiwyg/share/MediaWiki/extensions/MediaWikiWyg.php
——@@ -256,7 +256,7 @@
257257
258258 /* if (!in_array( 'ezparser', $wgUser->getRights() ) ) {
259259 $wgOut->setArticleRelated( false );
260 - $wgOut->setRobotpolicy( 'noindex,follow' );
 260+ $wgOut->setRobotPolicy( 'noindex,follow' );
261261 $wgOut->errorpage( 'nosuchspecialpage', 'nospecialpagetext' );
262262 return;
263263 }
Index: trunk/extensions/wikiwyg/share/MediaWiki/extensions/EZParser.php
——@@ -25,7 +25,7 @@
2626
2727 if (!in_array( 'ezparser', $wgUser->getRights() ) ) {
2828 $wgOut->setArticleRelated( false );
29 - $wgOut->setRobotpolicy( 'noindex,follow' );
 29+ $wgOut->setRobotPolicy( 'noindex,follow' );
3030 $wgOut->errorpage( 'nosuchspecialpage', 'nospecialpagetext' );
3131 return;
3232 }
Index: trunk/extensions/Player/SpecialPlayer.php
——@@ -126,7 +126,7 @@
127127 } else {
128128 # Just need to set the right headers
129129 $wgOut->setArticleFlag( false );
130 - $wgOut->setRobotpolicy( 'noindex,nofollow' );
 130+ $wgOut->setRobotPolicy( 'noindex,nofollow' );
131131 $this->viewUpdates();
132132 }
133133
Index: trunk/extensions/AssertEdit/AssertEdit.php
——@@ -59,7 +59,7 @@
6060 //slightly modified from showErrorPage(), to return back here.
6161 $wgOut->setPageTitle( wfMsg( 'assert_edit_title' ) );
6262 $wgOut->setHTMLTitle( wfMsg( 'errorpagetitle' ) );
63 - $wgOut->setRobotpolicy( 'noindex,nofollow' );
 63+ $wgOut->setRobotPolicy( 'noindex,nofollow' );
6464 $wgOut->setArticleRelated( false );
6565 $wgOut->enableClientCache( false );
6666 $wgOut->mRedirect = '';
Index: trunk/extensions/Invitations/Invitations_page.php
——@@ -40,7 +40,7 @@
4141 $sk = $wgUser->getSkin();
4242
4343 $wgOut->setPageTitle( wfMsg( 'invitations-pagetitle' ) );
44 - $wgOut->setRobotpolicy( "noindex,nofollow" );
 44+ $wgOut->setRobotPolicy( "noindex,nofollow" );
4545 $wgOut->setArticleRelated( false );
4646 $wgOut->enableClientCache( false );
4747
——@@ -110,7 +110,7 @@
111111 $friendlyname = wfMsg("invitation-type-$feature");
112112
113113 $wgOut->setPageTitle( wfMsg( 'invitations-feature-pagetitle', $friendlyname ) );
114 - $wgOut->setRobotpolicy( "noindex,nofollow" );
 114+ $wgOut->setRobotPolicy( "noindex,nofollow" );
115115 $wgOut->setArticleRelated( false );
116116 $wgOut->enableClientCache( false );
117117
Index: trunk/extensions/Postcomment/SpecialPostcomment.php
——@@ -91,7 +91,7 @@
9292 global $wgFeedClasses, $wgFilterCallback, $wgWhitelistEdit;
9393
9494
95 - $wgOut->setRobotpolicy( "noindex,nofollow" );
 95+ $wgOut->setRobotPolicy( "noindex,nofollow" );
9696 $fname = "wfSpecialPostcomment";
9797
9898 //echo "topic: " . $wgRequest->getVal("topic_name") . "<br />";
Index: trunk/extensions/OpenID/SpecialOpenIDConvert.body.php
——@@ -162,7 +162,7 @@
163163 $this->setUserUrl($wgUser, $openid_url);
164164
165165 $wgOut->setPageTitle( wfMsg( 'openidconvertsuccess' ) );
166 - $wgOut->setRobotpolicy( 'noindex,nofollow' );
 166+ $wgOut->setRobotPolicy( 'noindex,nofollow' );
167167 $wgOut->setArticleRelated( false );
168168 $wgOut->addWikiText( wfMsg( 'openidconvertsuccesstext', $openid_url ) );
169169 $wgOut->returnToMain( );
Index: trunk/extensions/OpenID/SpecialOpenIDFinish.body.php
——@@ -183,7 +183,7 @@
184184 $this->loginSetCookie($openid);
185185
186186 $wgOut->setPageTitle( wfMsg( 'openidsuccess' ) );
187 - $wgOut->setRobotpolicy( 'noindex,nofollow' );
 187+ $wgOut->setRobotPolicy( 'noindex,nofollow' );
188188 $wgOut->setArticleRelated( false );
189189 $wgOut->addWikiText( wfMsg( 'openidsuccess', $wgUser->getName(), $openid ) );
190190 $wgOut->returnToMain(false, $this->returnTo());
——@@ -537,7 +537,7 @@
538538 global $wgUser, $wgOut;
539539
540540 $wgOut->setPageTitle( wfMsg( 'openiderror' ) );
541 - $wgOut->setRobotpolicy( 'noindex,nofollow' );
 541+ $wgOut->setRobotPolicy( 'noindex,nofollow' );
542542 $wgOut->setArticleRelated( false );
543543 $wgOut->addWikiText( wfMsg( 'openidalreadyloggedin', $wgUser->getName() ) );
544544 $wgOut->returnToMain(false, $this->returnTo() );
Index: trunk/extensions/OpenID/SpecialOpenIDLogin.body.php
——@@ -91,7 +91,7 @@
9292 global $wgUser, $wgOut;
9393
9494 $wgOut->setPageTitle( wfMsg( 'openiderror' ) );
95 - $wgOut->setRobotpolicy( 'noindex,nofollow' );
 95+ $wgOut->setRobotPolicy( 'noindex,nofollow' );
9696 $wgOut->setArticleRelated( false );
9797 $wgOut->addWikiText( wfMsg( 'openidalreadyloggedin', $wgUser->getName() ) );
9898 $wgOut->returnToMain(false, $this->returnTo() );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r37968Refactor a bit preparatory to fixing bug 8068: rewrite the robot policy stuff...simetrical19:05, 23 July 2008

Status & tagging log