r37715 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r37714‎ | r37715 | r37716 >
Date:21:16, 15 July 2008
Author:brion
Status:old
Tags:
Comment:
Revert r37669: LinkerLinkAttributes hook doesn't seem to make a lot of sense. The parameters passed can't be modified, and they are escaped for output, making it unsuitable as a general extension hook.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/hooks.txt
@@ -753,12 +753,6 @@
754754 $specialPageAliases: associative array of magic words synonyms
755755 $lang: laguage code (string)
756756
757 -'LinkerLinkAttributes': At the end of Linker::getLinkAttributesInternal() just before the return
758 -&$this: Linker object
759 -$title: 'title' attribute string
760 -$class: 'class' attribute string
761 -&$result: Final attribute string
762 -
763757 'LinkerMakeExternalImage': At the end of Linker::makeExternalImage() just before the return
764758 &$url: the image url
765759 &$alt: the image's alt text
Index: trunk/phase3/includes/Linker.php
@@ -108,7 +108,6 @@
109109 $r .= " class=\"$class\"";
110110 }
111111 $r .= " title=\"$title\"";
112 - wfRunHooks( 'LinkerLinkAttributes', array( &$this, $title, $class, &$r ) );
113112 return $r;
114113 }
115114
Index: trunk/phase3/RELEASE-NOTES
@@ -188,7 +188,6 @@
189189 the database is potentially queried
190190 * (bug 9736) Redirects on Special:Fewestrevisions are now marked as such.
191191 * New date/time formats in Cs localization according to ČSN and PČP.
192 -* Added new hook LinkerLinkAttributes for modifying attributes of <a> tags.
193192 * Add a new hook SkinSetupSiteCss to allow extensions to define new stylesheets
194193 to load site wide, or modify the list of stylesheets to load. This can be useful
195194 for wiki farms who need a specific placement of the stylesheets to cascade right.

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r37669Added LinkerLinkAttributes hook.david22:29, 14 July 2008

Status & tagging log