r37709 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r37708‎ | r37709 | r37710 >
Date:19:51, 15 July 2008
Author:ialex
Status:old
Tags:
Comment:
Added some tabs in the generated html so that it is easier to read the <head> element
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
@@ -1015,10 +1015,10 @@
10161016 # If we use any dynamic CSS, make a little CDATA block out of it.
10171017 $s = '';
10181018 foreach( $stylesheets as $link ) {
1019 - $s .= "@import \"$link\";\n";
 1019+ $s .= "\t\t\t@import \"$link\";\n";
10201020 }
10211021 $s .= $rawcss;
1022 - if( $s != '' ) $this->usercss = "/*<![CDATA[*/\n{$s}/*]]>*/";
 1022+ if( $s != '' ) $this->usercss = "/*<![CDATA[*/\n{$s}\t\t/*]]>*/";
10231023
10241024 wfProfileOut( __METHOD__ );
10251025 }
Index: trunk/phase3/includes/Skin.php
@@ -280,14 +280,14 @@
281281 static function makeVariablesScript( $data ) {
282282 global $wgJsMimeType;
283283
284 - $r = "<script type= \"$wgJsMimeType\">/*<![CDATA[*/\n";
 284+ $r = array( "<script type= \"$wgJsMimeType\">/*<![CDATA[*/" );
285285 foreach ( $data as $name => $value ) {
286286 $encValue = Xml::encodeJsVar( $value );
287 - $r .= "var $name = $encValue;\n";
 287+ $r[] = "var $name = $encValue;";
288288 }
289 - $r .= "/*]]>*/</script>\n";
 289+ $r[] = "/*]]>*/</script>";
290290
291 - return $r;
 291+ return implode( "\n\t\t", $r );
292292 }
293293
294294 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r37718Revert r37709 so I can cleanly revert other changes to these linesbrion21:33, 15 July 2008

Status & tagging log