r37698 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r37697‎ | r37698 | r37699 >
Date:15:43, 15 July 2008
Author:demon
Status:old
Tags:
Comment:
Remove $use_index that has been commented out for about 31000 revisions. Quick testing shows forcing use of rev_timestamp or page_timestamp indexes to be slower, so there's no point in using them instead.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialAncientpages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialAncientpages.php
——@@ -25,7 +25,6 @@
2626 $db = wfGetDB( DB_SLAVE );
2727 $page = $db->tableName( 'page' );
2828 $revision = $db->tableName( 'revision' );
29 - #$use_index = $db->useIndexClause( 'cur_timestamp' ); # FIXME! this is gone
3029 $epoch = $wgDBtype == 'mysql' ? 'UNIX_TIMESTAMP(rev_timestamp)' :
3130 'EXTRACT(epoch FROM rev_timestamp)';
3231 return

Status & tagging log