r37646 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r37645‎ | r37646 | r37647 >
Date:14:37, 14 July 2008
Author:aaron
Status:old
Tags:
Comment:
* Add accesskeys (bug 14783)
* Remove some hardcoding
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticle.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/flaggedrevs.js (modified) (history)
  • /trunk/extensions/FlaggedRevs/language/FlaggedRevs.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -212,7 +212,7 @@
213213 #########
214214
215215 # Bump this number every time you change flaggedrevs.css/flaggedrevs.js
216 -$wgFlaggedRevStyleVersion = 26;
 216+$wgFlaggedRevStyleVersion = 27;
217217
218218 $wgExtensionFunctions[] = 'efLoadFlaggedRevs';
219219
Index: trunk/extensions/FlaggedRevs/FlaggedArticle.php
@@ -1355,8 +1355,11 @@
13561356 $form .= "<span id='mw-commentbox' style='clear:both'>" . Xml::inputLabel( wfMsg('revreview-log'), 'wpReason',
13571357 'wpReason', 50, '', array('class' => 'fr-comment-box') ) . "&nbsp;&nbsp;&nbsp;</span>";
13581358 }
1359 - $form .= Xml::submitButton( wfMsgHtml('revreview-submit'),
1360 - array('id' => 'mw-submitbutton','class' => 'fr-comment-box','accesskey' => 's')+$toggle );
 1359+ $form .= Xml::submitButton(
 1360+ wfMsgHtml('revreview-submit'), array('id' => 'submitreview',
 1361+ 'class' => 'fr-comment-box','accesskey' => wfMsg('revreview-ak-review'),
 1362+ 'title' => wfMsg('revreview-tt-review').' ['.wfMsg('revreview-ak-review').']' )+$toggle
 1363+ );
13611364 $form .= Xml::closeElement( 'span' );
13621365
13631366 $form .= Xml::closeElement( 'div' );
Index: trunk/extensions/FlaggedRevs/language/FlaggedRevs.i18n.php
@@ -159,10 +159,18 @@
160160 'stable-logpage' => 'Stability log',
161161 'stable-logpagetext' => 'This is a log of changes to the [[{{MediaWiki:Validationpage}}|stable version]] configuration of content pages.
162162 A list of stabilized pages can be found at the [[Special:StablePages|stable page list]].',
 163+
163164 'tooltip-ca-current' => 'View the current draft of this page',
 165+ 'tooltip-ca-stable' => 'View the stable version of this page',
164166 'tooltip-ca-default' => 'Quality assurance settings',
165 - 'tooltip-ca-stable' => 'View the stable version of this page',
 167+
 168+ 'revreview-ak-review' => 's', # do not translate or duplicate this message to other languages
 169+ 'accesskey-ca-current' => 'v', # do not translate or duplicate this message to other languages
 170+ 'accesskey-ca-stable' => 'c', # do not translate or duplicate this message to other languages
 171+
 172+ 'revreview-tt-review' => 'Review this page',
166173 'validationpage' => '{{ns:help}}:Article validation',
 174+
167175 );
168176
169177 /** Afrikaans (Afrikaans)
Index: trunk/extensions/FlaggedRevs/flaggedrevs.js
@@ -88,7 +88,7 @@
8989 notebox.style.display = quality ? 'inline' : 'none';
9090 }
9191 // If only a few levels are zero, don't show submit link
92 - var submit = document.getElementById('mw-submitbutton');
 92+ var submit = document.getElementById('submitreview');
9393 submit.disabled = ( somezero && !allzero ) ? 'disabled' : '';
9494 var comment = document.getElementById('wpReason');
9595 comment.disabled = ( somezero && !allzero ) ? 'disabled' : '';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r37524Add form accesskey (bug 14783)aaron18:44, 10 July 2008

Status & tagging log