r37529 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r37528‎ | r37529 | r37530 >
Date:19:51, 10 July 2008
Author:nikerabbit
Status:old
Tags:
Comment:
* Escaping, should also fix the weird double transform bug recently found
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
@@ -1295,7 +1295,7 @@
12961296 $editurl = '&section='.$section;
12971297 $url = $this->makeKnownLinkObj(
12981298 $nt,
1299 - wfMsg('editsection'),
 1299+ htmlspecialchars(wfMsg('editsection')),
13001300 'action=edit'.$editurl,
13011301 '', '', '', $hint
13021302 );
@@ -1311,9 +1311,9 @@
13121312 // For reverse compatibility, add the brackets *after* the hook is run,
13131313 // and even add them to hook-provided text.
13141314 if( is_null( $result ) ) {
1315 - $result = wfMsg( 'editsection-brackets', $url );
 1315+ $result = wfMsgHtml( 'editsection-brackets', $url );
13161316 } else {
1317 - $result = wfMsg( 'editsection-brackets', $result );
 1317+ $result = wfMsgHtml( 'editsection-brackets', $result );
13181318 }
13191319 return "<span class=\"editsection\">$result</span>";
13201320 }

Status & tagging log