r37513 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r37512‎ | r37513 | r37514 >
Date:17:02, 10 July 2008
Author:brion
Status:old
Tags:
Comment:
Revert r37490, 37493 for now -- 'NotifyOnPageChangeComplete hook added'
The hook seems a bit odd; it triggers on some of the composes, but not all. There's another loop right after this one.
Also, there's no need to pass objects as references here.
Modified paths:
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/includes/UserMailer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/hooks.txt
@@ -869,10 +869,6 @@
870870 &$langCode: the language code to get the message for (string) - or -
871871 whether to use the content language (true) or site language (false) (bool)
872872
873 -'NotifyOnPageChangeComplete': called after user email notification.
874 -$EmailNotification: EmailNotification object being used
875 -$watchingUser: user (object) to whom email was sent
876 -
877873 'OpenSearchUrls': Called when constructing the OpenSearch description XML.
878874 Hooks can alter or append to the array of URLs for search & suggestion formats.
879875 &$urls: array of associative arrays with Url element attributes
Index: trunk/phase3/includes/UserMailer.php
@@ -383,7 +383,6 @@
384384 $watchingUser->isEmailConfirmed() )
385385 {
386386 $this->compose( $watchingUser );
387 - wfRunHooks('NotifyOnPageChangeComplete', array( &$this, &$watchingUser ));
388387 }
389388 }
390389 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r37490NotifyOnPageChangeComplete hook addedeloy11:10, 10 July 2008

Status & tagging log