r3744 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r3743‎ | r3744 | r3745 >
Date:16:20, 29 May 2004
Author:timstarling
Status:old
Tags:
Comment:
Fixed bug in edit conflict merge feature -- didn't decompress old_text
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -542,7 +542,9 @@
543543 $res = wfQuery("SELECT old_text FROM old WHERE old_namespace = $ns AND ".
544544 "old_title = '{$title}' AND old_timestamp = '{$oldDate}'", DB_WRITE);
545545 $obj = wfFetchObject($res);
546 - if(wfMerge($obj->old_text, $text, $yourtext, $result)){
 546+ $oldText = Article::getRevisionText( $obj );
 547+
 548+ if(wfMerge($oldText, $text, $yourtext, $result)){
547549 $text = $result;
548550 return true;
549551 } else {

Status & tagging log