r37425 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r37424‎ | r37425 | r37426 >
Date:18:14, 9 July 2008
Author:demon
Status:old
Tags:
Comment:
(bug 14763) Strict standards issue in DatabasePostgres (also happened with DatabaseOracle, no one reported it though).
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/db/DatabaseOracle.php (modified) (history)
  • /trunk/phase3/includes/db/DatabasePostgres.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseOracle.php
@@ -696,8 +696,8 @@
697697 return 0;
698698 }
699699
700 - function setFakeSlaveLag() {}
701 - function setFakeMaster() {}
 700+ function setFakeSlaveLag( $lag ) {}
 701+ function setFakeMaster( $enabled = true ) {}
702702
703703 function getDBname() {
704704 return $this->mDBname;
Index: trunk/phase3/includes/db/DatabasePostgres.php
@@ -1357,8 +1357,8 @@
13581358 return false;
13591359 }
13601360
1361 - function setFakeSlaveLag() {}
1362 - function setFakeMaster() {}
 1361+ function setFakeSlaveLag( $lag ) {}
 1362+ function setFakeMaster( $enabled = true ) {}
13631363
13641364 function getDBname() {
13651365 return $this->mDBname;
Index: trunk/phase3/RELEASE-NOTES
@@ -429,6 +429,8 @@
430430 application/xhtml+xml. The calls to this have been removed.
431431 * (bug 14764) Fix regression in from Article::lastModified(), failed to work
432432 on non-mySQL schemas.
 433+* (bug 14763) Child classes of Database (DatabasePostgres and DatabaseOracle)
 434+ had stict standards issues with setFakeSlaveLag() and setFakeMaster().
433435
434436 === API changes in 1.13 ===
435437

Status & tagging log