r37377 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r37376‎ | r37377 | r37378 >
Date:09:28, 9 July 2008
Author:rotem
Status:old
Tags:
Comment:
Removing the ordered list workaround for Firefox in RTL: Firefox 3, released a few weeks ago, fixes this issue. The workaround causes problems with the numbering in Firefox. I think that it is better to remove this workaround because of its problems.

The unordered list workaround does not seem to cause problems; it should stay until most Firefox users upgrade to Firefox 3.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/common/common_rtl.css (modified) (history)
  • /trunk/phase3/skins/modern/rtl.css (modified) (history)
  • /trunk/phase3/skins/monobook/rtl.css (modified) (history)
  • /trunk/phase3/skins/simple/rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/rtl.css
@@ -227,9 +227,6 @@
228228 html > body div#bodyContent ul {
229229 display: table;
230230 }
231 -html > body div#bodyContent ol {
232 - display: table;
233 -}
234231 html > body div#bodyContent ul#filetoc {
235232 display: block;
236233 }
Index: trunk/phase3/skins/modern/rtl.css
@@ -141,9 +141,6 @@
142142 html > body div#mw_contentholder ul {
143143 display: table;
144144 }
145 -html > body div#mw_contentholder ol {
146 - display: table;
147 -}
148145 html > body div#mw_contentholder ul#filetoc {
149146 display: block;
150147 }
Index: trunk/phase3/skins/common/common_rtl.css
@@ -45,6 +45,3 @@
4646 html > body div#article ul {
4747 display: table;
4848 }
49 -html > body div#article ol {
50 - display: table;
51 -}
Index: trunk/phase3/skins/simple/rtl.css
@@ -173,6 +173,3 @@
174174 html > body div#bodyContent ul {
175175 display: table;
176176 }
177 -html > body div#bodyContent ol {
178 - display: table;
179 -}
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1353,7 +1353,7 @@
13541354 * to ensure that client-side caches don't keep obsolete copies of global
13551355 * styles.
13561356 */
1357 -$wgStyleVersion = '161';
 1357+$wgStyleVersion = '162';
13581358
13591359
13601360 # Server-side caching:

Status & tagging log