r37366 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r37365‎ | r37366 | r37367 >
Date:05:37, 9 July 2008
Author:werdna
Status:old
Tags:
Comment:
Oops. Fix weirdness
Modified paths:
  • /trunk/extensions/inputbox/inputbox.php (modified) (history)

Diff [purge]

Index: trunk/extensions/inputbox/inputbox.php
@@ -159,6 +159,10 @@
160160 $this->buttonlabel = wfMsgHtml( 'tryexact' );
161161 }
162162
 163+ $buttonlabel = htmlspecialchars( $this->buttonlabel );
 164+ $searchbuttonlabel = htmlspecialchars( $this->searchbuttonlabel );
 165+ $id = Sanitizer::escapeId( $this->id );
 166+
163167 $label = '';
164168 $styles = '';
165169
@@ -185,7 +189,7 @@
186190
187191 $type = $this->hidden ? 'hidden' : 'text';
188192 $searchform=<<<ENDFORM
189 -<form action="$search" class="bodySearch" {$styles} id="bodySearch{$id}"><div class="bodySearchWrap" style="{$styles}">{$label}<input type="{$type}" name="search" size="{$this->width}" class="bodySearchIput" id="bodySearchIput{$id}" /><input type="submit" name="go" value="{$buttonlabel}" class="bodySearchBtnGo" />
 193+<form action="$search" class="bodySearch" {$styles} id="bodySearch{$id}"><div class="bodySearchWrap" {$styles}>{$label}<input type="{$type}" name="search" size="{$this->width}" class="bodySearchIput" id="bodySearchIput{$id}" /><input type="submit" name="go" value="{$buttonlabel}" class="bodySearchBtnGo" />
190194 ENDFORM;
191195
192196 if ( !empty( $this->fulltextbtn ) ) // this is wrong...

Status & tagging log