r3726 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r3725‎ | r3726 | r3727 >
Date:22:46, 28 May 2004
Author:vibber
Status:old
Tags:
Comment:
Simplify the blockcache mData validity check to avoid other potential not-an-array crap from slipping in
Modified paths:
  • /trunk/phase3/includes/BlockCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/BlockCache.php
@@ -36,7 +36,7 @@
3737 }
3838 }
3939
40 - if ( $this->mData === false || is_null( $this->mData ) ) {
 40+ if ( !is_array( $this->mData ) ) {
4141 # Load from DB
4242 $this->mData = array();
4343 Block::enumBlocks( "wfBlockCacheInsert", "" ); # Calls $this->insert()

Status & tagging log