r37156 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r37155‎ | r37156 | r37157 >
Date:10:12, 6 July 2008
Author:nicdumz
Status:old
Tags:
Comment:
mResult is never used, removing it.
Modified paths:
  • /trunk/phase3/includes/HTMLCacheUpdate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HTMLCacheUpdate.php
@@ -27,7 +27,6 @@
2828 {
2929 public $mTitle, $mTable, $mPrefix;
3030 public $mRowsPerJob, $mRowsPerQuery;
31 - public $mResult;
3231
3332 function __construct( $titleTo, $table ) {
3433 global $wgUpdateRowsPerJob, $wgUpdateRowsPerQuery;
@@ -43,7 +42,7 @@
4443 $cond = $this->getToCondition();
4544 $dbr = wfGetDB( DB_SLAVE );
4645 $res = $dbr->select( $this->mTable, $this->getFromField(), $cond, __METHOD__ );
47 - $this->mResult = $res;
 46+
4847 if ( $dbr->numRows( $res ) != 0 ) {
4948 if ( $dbr->numRows( $res ) > $this->mRowsPerJob ) {
5049 $this->insertJobs( $res );

Status & tagging log