r37108 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r37107‎ | r37108 | r37109 >
Date:14:43, 5 July 2008
Author:demon
Status:old
Tags:
Comment:
Re-implement "Email user footer,"
* Now grabs message from global language instead of user's UI lang.
* Added a separator between msg and footer
* Shortened message
* Removed a bunch of useless params from the previous incarnation of this.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialEmailuser.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialEmailuser.php
@@ -148,7 +148,8 @@
149149 $from = new MailAddress( $wgUser );
150150 $subject = $this->subject;
151151
152 - $prefsTitle = Title::newFromText( 'Preferences', NS_SPECIAL );
 152+ // Add a standard footer
 153+ $this->text = $this->text . "\n ---- \n" . wfMsgForContent( 'emailuserfooter', array( $from->name, $to->name ) );
153154
154155 if( wfRunHooks( 'EmailUser', array( &$to, &$from, &$subject, &$this->text ) ) ) {
155156
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2038,6 +2038,7 @@
20392039 'emailccsubject' => 'Copy of your message to $1: $2',
20402040 'emailsent' => 'E-mail sent',
20412041 'emailsenttext' => 'Your e-mail message has been sent.',
 2042+'emailuserfooter' => 'This e-mail was sent by $1 to $2 by the "Email user" function at {{SITENAME}}.',
20422043
20432044 # Watchlist
20442045 'watchlist' => 'My watchlist',

Status & tagging log