r37105 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r37104‎ | r37105 | r37106 >
Date:14:18, 5 July 2008
Author:mkroetzsch
Status:old
Tags:
Comment:
declare only visible Factboxes as printed (still avoids Factbox duplicates, but behaves better with gallery)
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_Factbox.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/SMW_Factbox.php
@@ -213,7 +213,6 @@
214214 if (!$smwgStoreActive) return;
215215 if (SMWFactbox::$m_printed) return;
216216 wfProfileIn("SMWFactbox::printFactbox (SMW)");
217 - SMWFactbox::$m_printed = true;
218217
219218 // Global settings:
220219 if ( $wgRequest->getCheck('wpPreview') ) {
@@ -249,6 +248,7 @@
250249 break;
251250 // case SMW_FACTBOX_SHOWN: display
252251 }
 252+ SMWFactbox::$m_printed = true;
253253
254254 smwfRequireHeadItem(SMW_HEADER_STYLE);
255255 $rdflink = SMWInfolink::newInternalLink(wfMsgForContent('smw_viewasrdf'), $wgContLang->getNsText(NS_SPECIAL) . ':ExportRDF/' . SMWFactbox::$semdata->getSubject()->getPrefixedText(), 'rdflink');

Status & tagging log