r37067 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r37066‎ | r37067 | r37068 >
Date:21:23, 4 July 2008
Author:brion
Status:old
Tags:
Comment:
Revert r37063 "KTHMLfixes no longer loaded on skins where it doesn't exist. (bug 14717)"
* Hardcoding to monobook doesn't make sense here; other skins may include such fix files
* Only addressing KHTMLfixes doesn't make sense here; there's a big pile of Opera fixes right above it which would presumably suffer the same problem

If these are required, and are required per-skin, then the skin should probably specify to the JS which ones it needs.
On the other hand, if they're not required, or can be done in a skin-independent fashion, then that should be checked.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/wikibits.js
——@@ -92,7 +92,7 @@
9393 document.write('<link rel="stylesheet" type="text/css" href="'+stylepath+'/'+skin+'/Opera6Fixes.css">');
9494 } else if (is_opera_seven && !is_opera_95) {
9595 document.write('<link rel="stylesheet" type="text/css" href="'+stylepath+'/'+skin+'/Opera7Fixes.css">');
96 - } else if (is_khtml && skin == 'monobook' ) {
 96+ } else if (is_khtml) {
9797 document.write('<link rel="stylesheet" type="text/css" href="'+stylepath+'/'+skin+'/KHTMLFixes.css">');
9898 }
9999 }
Index: trunk/phase3/includes/DefaultSettings.php
——@@ -1353,7 +1353,7 @@
13541354 * to ensure that client-side caches don't keep obsolete copies of global
13551355 * styles.
13561356 */
1357 -$wgStyleVersion = '161';
 1357+$wgStyleVersion = '160';
13581358
13591359
13601360 # Server-side caching:
Index: trunk/phase3/RELEASE-NOTES
——@@ -413,7 +413,6 @@
414414 * (bug 14088) Excessively long block expiry times are rejected as invalid,
415415 keeps the log page from being distorted.
416416 * (bug 14708) Emulate INSERT...IGNORE with standard SQL for Postgres backend.
417 -* (bug 14717) Wikibits no longer tries to load KTHMLFixes on non-monobook skins
418417
419418 === API changes in 1.13 ===
420419

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r37063KTHMLfixes no longer loaded on skins where it doesn't exist. (bug 14717)demon16:43, 4 July 2008

Status & tagging log