r36962 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36961‎ | r36962 | r36963 >
Date:23:47, 2 July 2008
Author:brion
Status:old
Tags:
Comment:
Revert r36839 (merge of movepage-moved and movepage-page-moved) -- the two messages have different formats. One is wikitext, the other is plaintext.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialMovepage.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialMovepage.php
@@ -291,7 +291,7 @@
292292 $oldLink = "<span class='plainlinks'>[$oldUrl $oldText]</span>";
293293 $newLink = "<span class='plainlinks'>[$newUrl $newText]</span>";
294294
295 - $wgOut->addWikiMsg( 'movepage-page-moved', $oldLink, $newLink, $oldText, $newText );
 295+ $wgOut->addWikiMsg( 'movepage-moved', $oldLink, $newLink, $oldText, $newText );
296296
297297 # Now we move extra pages we've been asked to move: subpages and talk
298298 # pages. First, if the old page or the new page is a talk page, we
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2434,6 +2434,7 @@
24352435 'move-watch' => 'Watch this page',
24362436 'movepagebtn' => 'Move page',
24372437 'pagemovedsub' => 'Move succeeded',
 2438+'movepage-moved' => '<big>\'\'\'"$1" has been moved to "$2"\'\'\'</big>', # The two titles are passed in plain text as $3 and $4 to allow additional goodies in the message.
24382439 'articleexists' => 'A page of that name already exists, or the name you have chosen is not valid.
24392440 Please choose another name.',
24402441 'cantmove-titleprotected' => 'You cannot move a page to this location, because the new title has been protected from creation',
@@ -2444,7 +2445,7 @@
24452446 'move-subpages' => 'Move all subpages, if applicable',
24462447 'move-talk-subpages' => 'Move all subpages of talk page, if applicable',
24472448 'movepage-page-exists' => 'The page $1 already exists and cannot be automatically overwritten.',
2448 -'movepage-page-moved' => 'The page $1 has been moved to $2.', # The two titles are passed in plain text as $3 and $4 to allow additional goodies in the message.
 2449+'movepage-page-moved' => 'The page $1 has been moved to $2.',
24492450 'movepage-page-unmoved' => 'The page $1 could not be moved to $2.',
24502451 'movepage-max-pages' => 'The maximum of $1 {{PLURAL:$1|page|pages}} has been moved and no more will be moved automatically.',
24512452 '1movedto2' => '[[$1]] moved to [[$2]]',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r36839Removing movepage-moved, using movepage-page-moved in its place. The former w...huji11:22, 1 July 2008

Status & tagging log