r36957 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36956‎ | r36957 | r36958 >
Date:22:56, 2 July 2008
Author:brion
Status:old
Tags:
Comment:
Revert the rest of r36804 -- ExtendJSGlobalVars and wfMessageCacheReplace hooks.

ExtendJSGlobalVars is probably ok in function, though I don't really like its name.

wfMessageCacheReplace seems really unclear as to what it's trying to accomplish.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/includes/MessageCache.php (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/hooks.txt
@@ -600,10 +600,6 @@
601601 $subject: subject of the mail
602602 $text: text of the mail
603603
604 -'ExtendJSGlobalVars': called right before Skin::makeVariablesScript is executed
605 -&$vars: variable (or multiple variables) to be added into the output
606 - of Skin::makeVariablesScript
607 -
608604 'FetchChangesList': When fetching the ChangesList derivative for a particular user
609605 &$user: User the list is being fetched for
610606 &$skin: Skin object to be used with the list
@@ -1302,9 +1298,5 @@
13031299 'wgQueryPages': called when initialising $wgQueryPages, use this to add new query pages to be updated with maintenance/updateSpecialPages.php
13041300 $query: $wgQueryPages itself
13051301
1306 -'wfMessageCacheReplace': called after sidebar memcached key has been deleted, use this to replace core messages by using an extension
1307 -$title: title of the MediaWiki: message page
1308 -$text: text of the MediaWiki: message page
1309 -
13101302 More hooks might be available but undocumented, you can execute
13111303 ./maintenance/findhooks.php to find hidden one.
Index: trunk/phase3/includes/MessageCache.php
@@ -363,7 +363,6 @@
364364 }
365365 $this->unlock();
366366 $parserMemc->delete(wfMemcKey('sidebar'));
367 - wfRunHooks( 'wfMessageCacheReplace', array( $title, $text ) );
368367 wfProfileOut( __METHOD__ );
369368 }
370369
Index: trunk/phase3/includes/Skin.php
@@ -362,8 +362,6 @@
363363 $vars['wgAjaxWatch'] = $msgs;
364364 }
365365
366 - wfRunHooks('ExtendJSGlobalVars', array(&$vars));
367 -
368366 return self::makeVariablesScript( $vars );
369367 }
370368
Index: trunk/phase3/RELEASE-NOTES
@@ -175,7 +175,6 @@
176176 * Allow an $error message to be passed to ArticleDelete hook
177177 * Allow extensions to modify the user creation form by calling addInputItem();
178178 * Add meta generator tag to HTML output
179 -* Two new hooks, ExtendJSGlobalVars and wfMessageCacheReplace added
180179 * MediawikiPerformAction hook is now passed the Mediawiki object
181180 * Added blank special page Special:BlankPage for benchmarking, etc.
182181 * (bug 13862) Specialpages now has a horizontal TOC if there's three or more

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r36804Two new hooks and one new global function from Wikia codebaseashley08:42, 30 June 2008

Status & tagging log