r36940 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36939‎ | r36940 | r36941 >
Date:19:17, 2 July 2008
Author:brion
Status:old
Tags:
Comment:
* Fix final import step for ugly-URL case: the title on the form action was overridden by the query parameters from the form when doing a GET request
* Remove stray executable bit
Modified paths:
  • /trunk/extensions/ImportFreeImages/ImportFreeImages.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ImportFreeImages/ImportFreeImages.php
@@ -272,8 +272,10 @@
273273
274274 $q = $wgRequest->getText( 'q' );
275275
 276+ global $wgScript;
276277 $wgOut->addHTML(wfMsg ('importfreeimages_description') . "<br /><br />
277 - <form method=GET action='" . $importPage->escapeFullURL() . "'>".wfMsg('search').
 278+ <form method=GET action=\"$wgScript\">".wfMsg('search').
 279+ Xml::hidden( 'title', $importPage->getPrefixedDbKey() ) .
278280 ": <input type=text name=q value='" . htmlspecialchars($q) . "'><input type=submit value=".wfMsg('search')."></form>");
279281
280282 if ($q != '') {
Property changes on: trunk/extensions/ImportFreeImages/ImportFreeImages.php
___________________________________________________________________
Deleted: svn:executable
281283 - *

Status & tagging log