r36885 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36884‎ | r36885 | r36886 >
Date:07:36, 2 July 2008
Author:nikerabbit
Status:old
Tags:
Comment:
* Partial revert of r36692. Has been spewing fatal errors for few days already
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -62,7 +62,6 @@
6363 var $autoSumm = '';
6464 var $hookError = '';
6565 var $mPreviewTemplates;
66 - var $mBaseRevision = false;
6766
6867 # Form values
6968 var $save = false, $preview = false, $diff = false;
@@ -1723,7 +1722,8 @@
17241723 $db = wfGetDB( DB_MASTER );
17251724
17261725 // This is the revision the editor started from
1727 - $baseRevision = $this->getBaseRevision();
 1726+ $baseRevision = Revision::loadFromTimestamp(
 1727+ $db, $this->mTitle, $this->edittime );
17281728 if( is_null( $baseRevision ) ) {
17291729 wfProfileOut( $fname );
17301730 return false;
@@ -2321,15 +2321,4 @@
23222322 return false;
23232323 }
23242324 }
2325 -
2326 - function getBaseRevision() {
2327 - if ($this->mBaseRevision == false) {
2328 - $db = wfGetDB( DB_MASTER );
2329 - $baseRevision = Revision::loadFromTimestamp(
2330 - $db, $editor->mTitle, $editor->edittime );
2331 - return $this->mBaseRevision = $baseRevision;
2332 - } else {
2333 - return $this->mBaseRevision;
2334 - }
2335 - }
23362325 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r36692Core changes for AbuseFilter extension....werdna06:24, 27 June 2008

Status & tagging log