r36803 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36802‎ | r36803 | r36804 >
Date:08:15, 30 June 2008
Author:nikerabbit
Status:old
Tags:
Comment:
* 2008-06-30:1 More contrast in the new default page for Special translate
Modified paths:
  • /trunk/extensions/Translate/README (modified) (history)
  • /trunk/extensions/Translate/Translate.css (modified) (history)
  • /trunk/extensions/Translate/Translate.php (modified) (history)
  • /trunk/extensions/Translate/TranslatePage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/TranslatePage.php
@@ -394,11 +394,11 @@
395395 $hasSubblocks = is_array($blocks) && count($blocks);
396396
397397 if ( $desc !== null || $hasSubblocks ) {
398 - $out = "\n<fieldset>\n";
 398+ $out = "\n<fieldset class=\"mw-sp-translate-group\">\n";
399399 $out .= Xml::tags( 'legend', null, $label );
400400 $out .= $desc;
401401 } else {
402 - $out = "\n<ul><li>$label</li></ul><hr />";
 402+ $out = "\n<div class=\"mw-sp-translate-group\">$label</div>";
403403 }
404404
405405 if ( $hasSubblocks ) {
Index: trunk/extensions/Translate/Translate.php
@@ -11,7 +11,7 @@
1212 * @license http://www.gnu.org/copyleft/gpl.html GNU General Public License 2.0 or later
1313 */
1414
15 -define( 'TRANSLATE_VERSION', '9 (2008-06-29:2)' );
 15+define( 'TRANSLATE_VERSION', '9 (2008-06-30:1)' );
1616
1717 $wgExtensionCredits['specialpage'][] = array(
1818 'name' => 'Translate',
Index: trunk/extensions/Translate/Translate.css
@@ -44,4 +44,15 @@
4545 line-height: normal;
4646 }
4747
 48+fieldset.mw-sp-translate-group {
 49+ border: 1px dotted black;
 50+}
4851
 52+div.mw-sp-translate-group {
 53+ margin-left: 0.875em;
 54+ border-bottom: 1px dotted black;
 55+}
 56+
 57+.mw-sp-translate-group legend, div.mw-sp-translate-group {
 58+ font-weight: bold;
 59+}
\ No newline at end of file
Index: trunk/extensions/Translate/README
@@ -34,6 +34,7 @@
3535
3636 == Changes in version 10 ==
3737
 38+* 2008-06-30:1 More contrast in the new default page for Special translate
3839 * 2008-06-29:2 Branched core messages now load translations from trunk files too
3940
4041 == Changes in version 9 ==

Status & tagging log