r36796 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36795‎ | r36796 | r36797 >
Date:01:26, 30 June 2008
Author:danny_b
Status:old
Tags:
Comment:
* adding <meta name="generator" content="MediaWiki $wgVersion" />
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)
  • /trunk/phase3/skins/Modern.php (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/MonoBook.php
@@ -45,7 +45,7 @@
4646 * @access private
4747 */
4848 function execute() {
49 - global $wgUser;
 49+ global $wgUser, $wgVersion;
5050 $skin = $wgUser->getSkin();
5151
5252 // Suppress warnings to prevent notices about missing indexes in $this->data
@@ -60,6 +60,7 @@
6161 <meta http-equiv="Content-Type" content="<?php $this->text('mimetype') ?>; charset=<?php $this->text('charset') ?>" />
6262 <?php $this->html('headlinks') ?>
6363 <title><?php $this->text('pagetitle') ?></title>
 64+ <meta name="generator" content="MediaWiki <?php echo $wgVersion ?>" />
6465 <style type="text/css" media="screen, projection">/*<![CDATA[*/
6566 @import "<?php $this->text('stylepath') ?>/common/shared.css?<?php echo $GLOBALS['wgStyleVersion'] ?>";
6667 @import "<?php $this->text('stylepath') ?>/<?php $this->text('stylename') ?>/main.css?<?php echo $GLOBALS['wgStyleVersion'] ?>";
Index: trunk/phase3/skins/Modern.php
@@ -47,7 +47,7 @@
4848 * @access private
4949 */
5050 function execute() {
51 - global $wgUser;
 51+ global $wgUser, $wgVersion;
5252 $skin = $wgUser->getSkin();
5353
5454 // Suppress warnings to prevent notices about missing indexes in $this->data
@@ -62,6 +62,7 @@
6363 <meta http-equiv="Content-Type" content="<?php $this->text('mimetype') ?>; charset=<?php $this->text('charset') ?>" />
6464 <?php $this->html('headlinks') ?>
6565 <title><?php $this->text('pagetitle') ?></title>
 66+ <meta name="generator" content="MediaWiki <?php echo $wgVersion ?>" />
6667 <?php if(empty($this->data['printable']) ) { ?>
6768 <style type="text/css" media="screen, projection">/*<![CDATA[*/
6869 @import "<?php $this->text('stylepath') ?>/common/shared.css?<?php echo $GLOBALS['wgStyleVersion'] ?>";
Index: trunk/phase3/includes/OutputPage.php
@@ -1333,7 +1333,7 @@
13341334 public function headElement() {
13351335 global $wgDocType, $wgDTD, $wgContLanguageCode, $wgOutputEncoding, $wgMimeType;
13361336 global $wgXhtmlDefaultNamespace, $wgXhtmlNamespaces;
1337 - global $wgUser, $wgContLang, $wgUseTrackbacks, $wgTitle, $wgStyleVersion;
 1337+ global $wgUser, $wgContLang, $wgUseTrackbacks, $wgTitle, $wgStyleVersion, $wgVersion;
13381338
13391339 if( $wgMimeType == 'text/xml' || $wgMimeType == 'application/xhtml+xml' || $wgMimeType == 'application/xml' ) {
13401340 $ret = "<?xml version=\"1.0\" encoding=\"$wgOutputEncoding\" ?>\n";
@@ -1354,6 +1354,7 @@
13551355 }
13561356 $ret .= "xml:lang=\"$wgContLanguageCode\" lang=\"$wgContLanguageCode\" $rtl>\n";
13571357 $ret .= "<head>\n<title>" . htmlspecialchars( $this->getHTMLTitle() ) . "</title>\n";
 1358+ $ret .= "<meta name=\"generator\" content=\"MediaWiki " . $wgVersion . "\" />\n";
13581359 array_push( $this->mMetatags, array( "http:Content-type", "$wgMimeType; charset={$wgOutputEncoding}" ) );
13591360
13601361 $ret .= $this->getHeadLinks();

Status & tagging log