r36791 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36790‎ | r36791 | r36792 >
Date:22:29, 29 June 2008
Author:catrope
Status:old
Tags:
Comment:
Another regression from r36678: dieUsageMsg() expects an array, not varargs.
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryBase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryBase.php
@@ -326,7 +326,7 @@
327327 public function titleToKey($title) {
328328 $t = Title::newFromText($title);
329329 if(!$t)
330 - $this->dieUsageMsg('invalidtitle', $title);
 330+ $this->dieUsageMsg(array('invalidtitle', $title));
331331 return $t->getDbKey();
332332 }
333333
@@ -339,7 +339,7 @@
340340 $t = Title::newFromDbKey($key);
341341 # This really shouldn't happen but we gotta check anyway
342342 if(!$t)
343 - $this->dieUsageMsg('invalidtitle', $key);
 343+ $this->dieUsageMsg(array('invalidtitle', $key));
344344 return $t->getPrefixedText();
345345 }
346346

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r36678Use the proper Title methods in ApiQueryBase::titleToKey() and keyToTitle(). ...catrope15:48, 26 June 2008

Status & tagging log