r36741 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36740‎ | r36741 | r36742 >
Date:13:19, 27 June 2008
Author:yaron
Status:old
Tags:
Comment:
Removed replacement of spaces with underlines in query string of #formlink function
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_ParserFunctions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_ParserFunctions.php
@@ -63,7 +63,7 @@
6464 * 'Has color' around each element in the list, you could call the
6565 * following:
6666 *
67 - * {{#arraymap:blue;red;yellow|;|x|[[Has color:=x]]|;}}
 67+ * {{#arraymap:blue;red;yellow|;|x|[[Has color::x]]|;}}
6868 *
6969 *
7070 * 'arraymaptemplate' is called as:
@@ -110,11 +110,11 @@
111111 function sfRenderFormLink (&$parser, $inFormName = '', $inLinkStr = '', $inLinkType='', $inQueryStr = '') {
112112 $ad = SpecialPage::getPage('AddData');
113113 $link_url = $ad->getTitle()->getLocalURL() . "/$inFormName";
 114+ $link_url = str_replace(' ', '_', $link_url);
114115 if ($inQueryStr != '') {
115116 $link_url .= (strstr($link_url, '?')) ? '&' : '?';
116117 $link_url .= $inQueryStr;
117118 }
118 - $link_url = str_replace(' ', '_', $link_url);
119119 if ($inLinkType == 'button') {
120120 $str = "<form><input type=\"button\" value=\"$inLinkStr\" onclick=\"window.location.href='$link_url'\"></form>";
121121 } else {

Status & tagging log