r36731 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36730‎ | r36731 | r36732 >
Date:13:04, 27 June 2008
Author:werdna
Status:old
Tags:
Comment:
Respect DB prefixes in query.
Modified paths:
  • /trunk/extensions/AbuseFilter/SpecialAbuseFilter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/AbuseFilter/SpecialAbuseFilter.php
@@ -313,7 +313,8 @@
314314
315315 // We shouldn't have more than 100 filters, so don't bother paging.
316316 $dbr = wfGetDB( DB_SLAVE );
317 - $res = $dbr->select( array('abuse_filter', 'abuse_filter_action'), 'abuse_filter.*,group_concat(afa_consequence) AS consequences', array( ), __METHOD__, array( 'LIMIT' => 100, 'GROUP BY' => 'af_id' ),
 317+ $abuse_filter = $dbr->tableName( 'abuse_filter' );
 318+ $res = $dbr->select( array('abuse_filter', 'abuse_filter_action'), $abuse_filter.'.*,group_concat(afa_consequence) AS consequences', array( ), __METHOD__, array( 'LIMIT' => 100, 'GROUP BY' => 'af_id' ),
318319 array( 'abuse_filter_action' => array('LEFT OUTER JOIN', 'afa_filter=af_id' ) ) );
319320 $list = '';
320321 $editLabel = $this->canEdit() ? 'abusefilter-list-edit' : 'abusefilter-list-details';

Status & tagging log